From owner-freebsd-stable@freebsd.org Wed Nov 18 08:19:16 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21760A32F35 for ; Wed, 18 Nov 2015 08:19:16 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com [IPv6:2a00:1450:4010:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 948491832 for ; Wed, 18 Nov 2015 08:19:15 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by lbblt2 with SMTP id lt2so19970758lbb.3 for ; Wed, 18 Nov 2015 00:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=MgzNnsY2Y5MoK4Ut4JkTfXiUmybzDvkhQwXxH6x6+uA=; b=aEwikSq9iDcq37PIY3koQCY3qR+sz7d8SR/Ab4HRpMomn2cyZOILJXQkdUzbXwBktH ecAcCXMfwuQmnGIuT1vFM6SBXQx9mBNUkrVV6iMmyavNNdEf16SzbtmO7DS3YHuv/DC1 OA+xzb5PDkahpoKZpxHOPp3duGrXZ4LB9hbm4EwPdGc9cKgMiRq0oWOGS/YQ6ffDFVg6 reaEMkk63125EhigD00kDzWneMZaem/nwUewNuwv32KD1HpGY3Z5HDokdA4/yiIQSHGs c1V6kKMC/BTRTFPK8PCKTKlzXciLg7qOfGSZeHOH6lBkm1brGga6qndKMbWFOYqJ7et8 KAVg== X-Received: by 10.112.235.65 with SMTP id uk1mr102414lbc.118.1447834753486; Wed, 18 Nov 2015 00:19:13 -0800 (PST) Received: from mavbook.mavhome.dp.ua ([2a01:d0:c0a9:3:c685:8ff:fe11:1aa2]) by smtp.googlemail.com with ESMTPSA id h37sm255318lfi.8.2015.11.18.00.19.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2015 00:19:12 -0800 (PST) Sender: Alexander Motin Message-ID: <564C347E.3030705@FreeBSD.org> Date: Wed, 18 Nov 2015 10:19:10 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steven Hartland , freebsd-stable@freebsd.org Subject: Re: Bug 204641 - 10.2 UNMAP/TRIM not available on a zfs zpool that uses iSCSI disks, backed on a zpool file target References: <564BC646.5070708@multiplay.co.uk> In-Reply-To: <564BC646.5070708@multiplay.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2015 08:19:16 -0000 On 18.11.2015 02:28, Steven Hartland wrote: > On 17/11/2015 22:08, Christopher Forgeron wrote: >> I just submitted this as a bug: >> >> ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204641 ) >> >> ..but I thought I should bring it to the list's attention for more >> exposure >> - If that's a no-no, let me know, as I have a few others that are related >> to this that I'd like to discuss. > Having a quick flick through the code it looks like umap is now only > supported on dev backed and not file backed. > > I believe the following commit is the cause: > https://svnweb.freebsd.org/base?view=revision&revision=279005 > > This was an MFC of: > https://svnweb.freebsd.org/base?view=revision&revision=278672 > > I'm guessing this was an unintentional side effect mav? As I have replied on the ticket: CTL never supported UNMAP on file-backed LUNs due to lack of respective API for hole punching on FreeBSD. At this time UNMAP works for ZVOLs in both device and file modes and raw devices. -- Alexander Motin