From owner-freebsd-net Mon Jan 11 03:18:35 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA17402 for freebsd-net-outgoing; Mon, 11 Jan 1999 03:18:35 -0800 (PST) (envelope-from owner-freebsd-net@FreeBSD.ORG) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id DAA17186 for ; Mon, 11 Jan 1999 03:18:05 -0800 (PST) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id KAA19980; Mon, 11 Jan 1999 10:12:10 +0100 From: Luigi Rizzo Message-Id: <199901110912.KAA19980@labinfo.iet.unipi.it> Subject: HEADS UP: critical dummynet patch To: net@FreeBSD.ORG Date: Mon, 11 Jan 1999 10:12:09 +0100 (MET) X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org This one is a critical fix for dummynet operation. Please update your copy of netinet/ip_dummynet.c or at least apply the following patch: diff -u -r1.3 -r1.4 --- ip_dummynet.c 1998/12/31 07:35:49 1.3 +++ ip_dummynet.c 1999/01/11 11:08:07 1.4 @@ -308,6 +318,7 @@ m_freem(m); return 0 ; /* XXX error */ } + bzero(pkt, sizeof(*pkt) ); /* build and enqueue packet */ pkt->hdr.mh_type = MT_DUMMYNET ; (struct ip_fw_chain *)pkt->hdr.mh_data = rule ; cheers luigi > From majordom@FreeBSD.ORG Mon Jan 11 10:03:11 1999 > Delivered-To: vmailer-cvs-all@freebsd.org > From: Luigi Rizzo > Date: Mon, 11 Jan 1999 03:08:09 -0800 (PST) > Message-Id: <199901111108.DAA02953@freefall.freebsd.org> > To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG > Subject: cvs commit: src/sys/netinet ip_dummynet.c > Sender: owner-cvs-all@FreeBSD.ORG > Precedence: bulk > > luigi 1999/01/11 03:08:09 PST > > Modified files: > sys/netinet ip_dummynet.c > Log: > Add a missing bzero which could be the source of instability > problems reported recently (the rtentry pointer in the dummynet > queue was not initialized in all cases, resulting in spurious > rt_refcnt decreases in the lucky cases, and memory trashing in > other cases. > > Revision Changes Path > 1.4 +21 -12 src/sys/netinet/ip_dummynet.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message