Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Feb 2004 11:07:28 +0100 (CET)
From:      Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        portmgr@FreeBSD.org
Subject:   ports/63297: [patch] bsd.port.mk: Wrong comment for PKGNAMESUFFIX
Message-ID:  <200402241007.i1OA7SMj069374@menelaos.informatik.rwth-aachen.de>
Resent-Message-ID: <200402241010.i1OAADhm000198@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         63297
>Category:       ports
>Synopsis:       [patch] bsd.port.mk: Wrong comment for PKGNAMESUFFIX
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 24 02:10:13 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Volker Stolz
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
Lehrstuhl für Informatik II
>Environment:
System: FreeBSD menelaos.informatik.rwth-aachen.de 4.9-STABLE FreeBSD 4.9-STABLE #12: Mon Dec 8 15:14:27 CET 2003 root@menelaos.informatik.rwth-aachen.de:/usr/obj/usr/src/sys/MENELAOS i386


>Description:
bsd.port.mk states that one shouldn't set PKGNAMESUFFIX (see below). It looks like this
comment originally belonged to PKGNAME (cf. rev. 1.334).
http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.333&r2=1.334&f=h

# PKGNAME               - Always defined as
#                                 ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}-${PORTVERSION}.
# PKGNAMEPREFIX - Prefix to specify that port is language-specific, etc.
#                                 Optional.
# PKGNAMESUFFIX - Suffix to specify compilation options.  Optional.
#                                 Do not define this in your Makefile.
                                ****************************************

>How-To-Repeat:
>Fix:
Move comment to where it belongs.

--- /usr/ports/Mk/bsd.port.mk	Thu Feb  5 10:33:51 2004
+++ bsd.port.mk	Tue Feb 24 11:02:45 2004
@@ -65,10 +65,10 @@
 #				  Default: 0 (no effect).
 # PKGNAME		- Always defined as
 #				  ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}-${PORTVERSION}.
+#				  Do not define this in your Makefile.
 # PKGNAMEPREFIX	- Prefix to specify that port is language-specific, etc.
 #				  Optional.
 # PKGNAMESUFFIX	- Suffix to specify compilation options.  Optional.
-#				  Do not define this in your Makefile.
 # UNIQUENAME	- A name for your port that is globally unique.  By default,
 # 				  this is set to ${LATEST_LINK} when LATEST_LINK is set,
 # 				  and to ${PKGNAMEPREFIX}${PORTNAME} otherwise.
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402241007.i1OA7SMj069374>