From owner-cvs-all Thu Jul 5 12:54:30 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (fw2.aub.dk [195.24.1.195]) by hub.freebsd.org (Postfix) with ESMTP id C272937B406; Thu, 5 Jul 2001 12:54:21 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f65JsAn07640; Thu, 5 Jul 2001 21:54:10 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Mike Smith Cc: Joerg Wunsch , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h In-Reply-To: Your message of "Tue, 03 Jul 2001 13:51:18 PDT." <200107032051.f63KpIm01502@mass.dis.org> Date: Thu, 05 Jul 2001 21:54:10 +0200 Message-ID: <7638.994362850@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >> > > sys/sys bio.h >> > > Log: >> > > Define BIO_CMD{1,2}, available for local hacks, similar to the already >> > > existing BIO_FLAG{1,2}. To be used in the fdc(4) driver soon. As the legal custodian of bio.h, I would like to express my displeasure with this commit as well. I have looked at what the FD driver does myself when I tried to implement the bio structure. I think the FD driver has a rather Oedipudian relationship with struct buf/bio. If you isist that the FD driver continue this praxis, please move these definitions to the driver source code so it doesn't pollute future code or minds. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message