From owner-svn-src-all@freebsd.org Wed Dec 6 06:50:50 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F979E977F8; Wed, 6 Dec 2017 06:50:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 59B2A660AB; Wed, 6 Dec 2017 06:50:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 90EDB5BED; Wed, 6 Dec 2017 06:50:49 +0000 (UTC) Date: Wed, 6 Dec 2017 06:50:49 +0000 From: Alexey Dokuchaev To: Conrad Meyer Cc: Cy Schubert , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers , Eitan Adler Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee Message-ID: <20171206065049.GA9434@FreeBSD.org> References: <201712052016.vB5KGc9T038423@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 06:50:50 -0000 [ Charset UTF-8 unsupported, converting... ] On Tue, Dec 05, 2017 at 01:06:40PM -0800, Conrad Meyer wrote: > On Tue, Dec 5, 2017 at 12:16 PM, Cy Schubert wrote: > > In message [...], Eitan Adler writes: > >> I'm not near my commit box right now so someone will have to revert > >> it. What's funny is that I ran a complete 'make buildworld > >> buildkernel' last night with this patch. > >> > >> Will respond to the rest of the thread later[.] > > > > No problem. r326575 addresses the issue. > > Not fully -- it doesn't address that the code is functionally broken or > that the change touched things it didn't need to. I think a revert is > still called for, when you can reach a machine with commit access. While it was already reverted, all the input so far raises a question of should it be readded even if/when fixed, since it apparently can be done with existing shell tools, in a better way [1]. I'd like us to have a smaller, orthogonal base, with tools not repeating themselves. ./danfe [1] https://lists.freebsd.org/pipermail/svn-src-head/2017-December/107001.html