Date: Mon, 20 Feb 2017 16:40:36 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313878 - head/sys/kern Message-ID: <5f23ee02-e200-5fcb-204d-fff24acfa171@FreeBSD.org> In-Reply-To: <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org> References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3dHeAkJpdw256mbN7WWqlpnvVsB05kKU0 Content-Type: multipart/mixed; boundary="F9Nm7SvxVGsOjk3mU4WfFNAl28o45lIDK"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5f23ee02-e200-5fcb-204d-fff24acfa171@FreeBSD.org> Subject: Re: svn commit: r313878 - head/sys/kern References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org> In-Reply-To: <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org> --F9Nm7SvxVGsOjk3mU4WfFNAl28o45lIDK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/20/2017 4:24 PM, Bryan Drewery wrote: > On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >> Author: mjg >> Date: Fri Feb 17 15:40:24 2017 >> New Revision: 313878 >> URL: https://svnweb.freebsd.org/changeset/base/313878 >> >> Log: >> mtx: get rid of file/line args from slow paths if they are unused >> =20 >> This denotes changes which went in by accident in r313877. >=20 > I really wish people would just revert their changes and recommit them > properly. The 'svn blame' on the code in r313877 will never show the > commit message here (r313878). So a person would only find this > explanation if they read 'svn log' on the file, which in the case of > sys/kern/kern_mutex.c there are 273 commits for. Are we expected to > read 'svn log' (in the future) for all changes in the hopes that a late= r > commit happens to mention it? >=20 > As someone who so often is 'svn blame'ing code to understand it better > and to track regressions, commits like this that explain other commits > might as well have never been done. https://lists.freebsd.org/pipermail/svn-src-all/2017-February/139904.html= is a case just now that is similar here. Personally I do look in the list archives for svn-src-all for additional discussion on commits. In the case of r313982, the discussion and author's admission that the commit message wasn't quite right are documented along with the commit at least on lists.freebsd.org and our own archives. >=20 >> =20 >> On most production kernels both said parameters are zeroed and have = nothing >> reading them in either __mtx_lock_sleep or __mtx_unlock_sleep. Thus = this change >> stops passing them by internal consumers which this is the case. >> =20 >> Kernel modules use _flags variants which are not affected kbi-wise. >> >> Modified: >> head/sys/kern/kern_mutex.c >> >> Modified: head/sys/kern/kern_mutex.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/kern/kern_mutex.c Fri Feb 17 15:34:40 2017 (r313877) >> +++ head/sys/kern/kern_mutex.c Fri Feb 17 15:40:24 2017 (r313878) >> @@ -622,7 +622,7 @@ __mtx_lock_sleep(volatile uintptr_t *c,=20 >> LOCKSTAT_RECORD1(adaptive__block, m, sleep_time); >> =20 >> /* >> - * Only record the loops spinning and not sleeping.=20 >> + * Only record the loops spinning and not sleeping. >> */ >> if (lda.spin_cnt > sleep_cnt) >> LOCKSTAT_RECORD1(adaptive__spin, m, all_time - sleep_time); >> >=20 >=20 --=20 Regards, Bryan Drewery --F9Nm7SvxVGsOjk3mU4WfFNAl28o45lIDK-- --3dHeAkJpdw256mbN7WWqlpnvVsB05kKU0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJYq4yEAAoJEDXXcbtuRpfPgf8H/0zedecPd9hVA/t/0d33iURy i3dUieRKxt57Q/kPZlC1wHb2YNRXq6yYrTVOS8DdM8P7SwqHraBgneo3SCx/yaw5 Jh+/thAEG67nVWjnzZFBjPTvV9jBjG3hFI4z+NgXkp7G7G0kIllJ6ITz2tXWylxU OEXnnEPFVg5iXNnbm6qCBowrD2rMXsBIkNyZ7B+V+59z1QBUyy3I9YFPsWoYYeip po+JTqVb07YikukNb6g5hAJiYvcNhQkDXnLOyyKWG3tmhXNM2WrXnYa+nXDkENVE 9Q8KmuMcbWCmG9PnlPZPlcN6A8X/nRDeBcXuvdIwhJnWHpJVWtU8nj/uG/3Q2xo= =Xw6X -----END PGP SIGNATURE----- --3dHeAkJpdw256mbN7WWqlpnvVsB05kKU0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5f23ee02-e200-5fcb-204d-fff24acfa171>