From owner-svn-ports-head@freebsd.org  Tue Dec  8 14:46:50 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D13F9D46D3;
 Tue,  8 Dec 2015 14:46:50 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AE7491D44;
 Tue,  8 Dec 2015 14:46:49 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id ad198bc6
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Tue, 8 Dec 2015 07:46:40 -0700 (MST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
Subject: Re: svn commit: r403235 - head/emulators/fuse-roms
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <290DB4608132EE92B98C7908@ogg.in.absolight.net>
Date: Tue, 8 Dec 2015 07:46:38 -0700
Cc: =?utf-8?Q?Ren=C3=A9_Ladan?= <rene@freebsd.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <535A55E7-560F-4F2C-B9D4-AB83FFAB3C12@adamw.org>
References: <201512072100.tB7L0Gnj081781@repo.freebsd.org>
 <0644124C99ECCEA1DF8E9EC0@atuin.in.mat.cc>
 <CADL2u4itn-bkKZkKj7rq9RGtkKpqQFJsh9pLUTiFKQ8bdg8Ssw@mail.gmail.com>
 <98D8063B4D072B57DAA53BE8@ogg.in.absolight.net>
 <CADL2u4jdeGOR-MMgbbuaGYbHMXuPT_Jn43jXpBxb_9Hu=-70Ag@mail.gmail.com>
 <290DB4608132EE92B98C7908@ogg.in.absolight.net>
To: Mathieu Arnold <mat@FreeBSD.org>
X-Mailer: Apple Mail (2.3096.5)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 14:46:50 -0000

> On 8 Dec, 2015, at 4:45, Mathieu Arnold <mat@FreeBSD.org> wrote:
>=20
>=20
>=20
> +--On 8 d=C3=A9cembre 2015 11:46:01 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org> wrote:
> | 2015-12-08 11:29 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
> |> +--On 8 d=C3=A9cembre 2015 10:08:19 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org>
> |> wrote:
> |> | 2015-12-08 10:04 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
> |> |> +--On 7 d=C3=A9cembre 2015 21:00:16 +0000 Rene Ladan =
<rene@FreeBSD.org>
> |> |> wrote:
> |> |> | +DOCS_PLIST_FILES=3D%%DOCSDIR%%/rom-distribution.txt
> |> |>=20
> |> |> When possible, don't use %%FOO%% thingies in PLIST_FILES, you =
can use
> |> |> ${DOCSDIR} directly.
> |> |>=20
> |> | I think I tried that before. It would almost work but "poudriere
> |> | testport" would fail.
> |>=20
> |> Then there was a bug in poudriere testport at that time. It now =
works.
> |>=20
> | That was in the previous version (3.10.9 ?). 'make check-plist' =
worked
> | fine. I'll change the line next time (but why is it bad?)
>=20
> The only reason there are %%foo%% thingies is because pkg-plist is a =
static
> file, and we need some way to do the variable expansion in them.  The
> PLIST_FILES is in the Makefile, you can put the correct variables =
directly.

Wouldn't using ${DOCSDIR_REL} be closer to what %%DOCSDIR%% expands to?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org