From owner-svn-src-head@freebsd.org  Thu Apr 12 15:50:20 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84AF9F9F43D;
 Thu, 12 Apr 2018 15:50:20 +0000 (UTC)
 (envelope-from benno@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 37745860EE;
 Thu, 12 Apr 2018 15:50:20 +0000 (UTC)
 (envelope-from benno@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3264A5536;
 Thu, 12 Apr 2018 15:50:20 +0000 (UTC)
 (envelope-from benno@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w3CFoJ1p089243;
 Thu, 12 Apr 2018 15:50:19 GMT (envelope-from benno@FreeBSD.org)
Received: (from benno@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w3CFoJsE089242;
 Thu, 12 Apr 2018 15:50:19 GMT (envelope-from benno@FreeBSD.org)
Message-Id: <201804121550.w3CFoJsE089242@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: benno set sender to
 benno@FreeBSD.org using -f
From: Benno Rice <benno@FreeBSD.org>
Date: Thu, 12 Apr 2018 15:50:19 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r332437 - head/usr.bin/etdump
X-SVN-Group: head
X-SVN-Commit-Author: benno
X-SVN-Commit-Paths: head/usr.bin/etdump
X-SVN-Commit-Revision: 332437
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Apr 2018 15:50:20 -0000

Author: benno
Date: Thu Apr 12 15:50:19 2018
New Revision: 332437
URL: https://svnweb.freebsd.org/changeset/base/332437

Log:
  Check the return value of fseek.
  
  Reported by:	Coverity
  CID:		1388267
  Sponsored by:	iXsystems, Inc.

Modified:
  head/usr.bin/etdump/etdump.c

Modified: head/usr.bin/etdump/etdump.c
==============================================================================
--- head/usr.bin/etdump/etdump.c	Thu Apr 12 15:47:47 2018	(r332436)
+++ head/usr.bin/etdump/etdump.c	Thu Apr 12 15:50:19 2018	(r332437)
@@ -80,7 +80,9 @@ static int
 read_sector(FILE *iso, daddr_t sector, char *buffer)
 {
 
-	fseek(iso, sector * ISO_DEFAULT_BLOCK_SIZE, SEEK_SET);
+	if (fseek(iso, sector * ISO_DEFAULT_BLOCK_SIZE, SEEK_SET) != 0) {
+		return (errno);
+	}
 	if (fread(buffer, ISO_DEFAULT_BLOCK_SIZE, 1, iso) != 1) {
 		return (errno);
 	}