From owner-svn-src-head@freebsd.org Thu Nov 22 05:24:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18B63113856D; Thu, 22 Nov 2018 05:24:35 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463848B252; Thu, 22 Nov 2018 05:24:34 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lj1-f193.google.com with SMTP id l15-v6so6830365lja.9; Wed, 21 Nov 2018 21:24:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fhrpDQY17AQirD3tA9zQ9OFiIeJVgaH2w9LaeQuNDRY=; b=gLtXqCJfNvPXtYjQVemx6DNyxjIaYz35icqI7gXvfuQ8qf2BEpjQKxf+3qmh6nhqOY urvWhO6XLM5ijzX0/8ra1S4ilhxie9mSe9Q+RPYn+FwrnpyiTXwjNJedyC/5XqVdUswv SnL+uzRdfLBsdU5LAmqkmbMje8OnvLxuFSLzr2JLrvkqHEiHuBE0u++MpnLrvN1gslz0 yM5hUHsiiAPrLqIWS9uu9KJ26JQw+3Xm86M7zn/wavdxZkk5vL4M9VjOtf8y8FyIDkqk QCVHSsh1EWNLm98gNpKZgRwI3qJSiwqbgiBFyPXB2YWJgpoEmDUCQBF5OA+nxUiw1K2E Xzfg== X-Gm-Message-State: AA+aEWbktAQoFZz4LOS6n0dx/381NQ+SJHLNVe+QbY6kQC7BHdP1L1Sy Q/+gj1aKVE2cZt/I5bWb9Ed1pGDgibqncUi0vDdWOw== X-Google-Smtp-Source: AJdET5dSxA2aMTjR6+7c3pP/HzgAhxJ629UeQ5OUpSa41SkVecDFHCaitbfxBrhblCLhecNQW9u6CwwkVTeNy49o1OY= X-Received: by 2002:a2e:4c1a:: with SMTP id z26-v6mr6302139lja.136.1542863876868; Wed, 21 Nov 2018 21:17:56 -0800 (PST) MIME-Version: 1.0 References: <201810210208.w9L28vVc080088@repo.freebsd.org> In-Reply-To: From: Justin Hibbits Date: Wed, 21 Nov 2018 23:17:44 -0600 Message-ID: Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc To: kevans@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 463848B252 X-Spamd-Result: default: False [-3.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.99)[-0.992,0]; IP_SCORE(-1.02)[ipnet: 209.85.128.0/17(-3.45), asn: 15169(-1.57), country: US(-0.09)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.91)[-0.913,0]; RCVD_IN_DNSWL_NONE(0.00)[193.208.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[jhibbits@freebsd.org,chmeeedalf@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[193.208.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[jhibbits@freebsd.org,chmeeedalf@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 05:24:35 -0000 On Wed, Nov 21, 2018 at 10:02 PM Kyle Evans wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits wrote: > > > > > > Author: jhibbits > > > Date: Sun Oct 21 02:08:57 2018 > > > New Revision: 339516 > > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > > > Log: > > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > > > before the genassym is completed. This causes a build failure when PSL_EE > > > doesn't exist, and is read as 0. Get around this by explicitly specifying > > > the bits in the mask instead. > > > > > > > Hi, > > > > CI on the stable/12 branch still hits this, so I'm tempted to MFC this > > if you don't object. OTOH, the correct solution should be a > > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > > dtrace_asm.S, no? > > > > Sorry, that should have read "genassym.inc" -- my naive understanding > of 'dependency' is that config(8) will turn it directly into a > makefile dependency that will alleviate this. Hm, I'm surprised we don't have a rule for all kernel .S files, even modules, being dependent on that. Should we add one? - Justin