From owner-svn-src-all@FreeBSD.ORG Wed Feb 25 15:44:14 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 41AA562B for ; Wed, 25 Feb 2015 15:44:14 +0000 (UTC) Received: from nm8-vm0.bullet.mail.bf1.yahoo.com (nm8-vm0.bullet.mail.bf1.yahoo.com [98.139.213.95]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D9FC399B for ; Wed, 25 Feb 2015 15:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1424879052; bh=rd0T3OpPRuzwOmKbwZZJHwBOLzzKv1vSjl64BFdQcVY=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=a5/l+MKAWvQu/NGGE9wpNBprH5D2AWrKQPOBn06hRt3sdX2FErYXpai95R/NHCRzKHgiaImnSFWdcSQbQRPfi54PULxCwHDzL65c7rnpfxZQORyWJmp59FxmhVezt2ILTO4G+NFUrue5efx+tg6Zty+4R/HIqJfcsWQ4yDdImwdYvjHp5wwVyjlwnYqxok+44EzMiLPzLaD2NYl9VJhzdJ+L7Qco8wJq4qZJcyfjMi5gAo5IGg7wadVPbM3tc24lwSse5Mtwa1ScrhpKK8Bc7ADm8lC+3axITlFP1F+mc0cSvcYuRMvYU5RZurnhe/SW9ozSNzKRYN2jlefKYsJA/g== Received: from [66.196.81.170] by nm8.bullet.mail.bf1.yahoo.com with NNFMP; 25 Feb 2015 15:44:12 -0000 Received: from [98.139.211.195] by tm16.bullet.mail.bf1.yahoo.com with NNFMP; 25 Feb 2015 15:44:12 -0000 Received: from [127.0.0.1] by smtp204.mail.bf1.yahoo.com with NNFMP; 25 Feb 2015 15:44:12 -0000 X-Yahoo-Newman-Id: 104145.25607.bm@smtp204.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: uvqKkIUVM1kU5JWB5rDuwZBfm9d7cd0MVbk1tHZuZeWgcI9 Gyvd7ZfUUJO5barJ7Hxul6FV68QtFI5qOkatYJWbTbMgFtpYMWombs3cRHqA m57VrJRYBvk8WK_ycHtI2fyBKZOpbgGBVPikd.R99CesO7vuAACTMrDikKdq ZM5KS9AzyoGMd.7qBUjWYy7eacTMHwK0Ns.tzF6R4.aheO9kND7YVAdXEQeU X6_jz7lQVjXXklpUfAgnbpUsxoE9Db87vPs0SbjFcBUamIbMSIGMW5Ojw7T5 _DADJUvV.LNbdLlu6xTTei7SQcz3FydYDJ2VVTNQ6UAniSKNUOvAbdmwSz3J hs.0VX_jUlJyfPrMEyjy1rlaoRyDUhHaogXXuzcnrOzSd_6.q.yHJRib.sf3 EW8p6Pff1zAEVWzlA_7_m_JHaYRE6CoNRSloiqhYLLAW80zKBoeMprPdnzpo uZ0VjOC1ghljZ4n4G2WK1BpZEnQGv5z8kQBl3ILilSj1DB8Q8zydpKvvo61J iiN8QvYXGRruL59sS47rg1ZwV5WFkkuhEHonVoFlgXnaZ_U_alF3V86cyEGo Ain7or4F8QFPqw9h8Lzykd3sJPsQNRyjvdIFO2Z35Dp4EZA1a9ElWiYDZxN3 OdXL4Uj0- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <54EDEDCE.80801@FreeBSD.org> Date: Wed, 25 Feb 2015 10:44:14 -0500 From: Pedro Giffuni Organization: FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r279275 - head/sys/boot/fdt References: <201502250957.t1P9v5hU004973@svn.freebsd.org> In-Reply-To: <201502250957.t1P9v5hU004973@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2015 15:44:14 -0000 On 25/02/2015 04:57 a.m., Alexander Motin wrote: > Author: mav > Date: Wed Feb 25 09:57:05 2015 > New Revision: 279275 > URL: https://svnweb.freebsd.org/changeset/base/279275 > > Log: > Fix potential NULL dereference. > > Submitted by: Dmitry Luhtionov > MFC after: 2 weeks > > Modified: > head/sys/boot/fdt/fdt_loader_cmd.c > > Modified: head/sys/boot/fdt/fdt_loader_cmd.c > ============================================================================== > --- head/sys/boot/fdt/fdt_loader_cmd.c Wed Feb 25 09:21:59 2015 (r279274) > +++ head/sys/boot/fdt/fdt_loader_cmd.c Wed Feb 25 09:57:05 2015 (r279275) > @@ -1299,13 +1299,12 @@ fdt_merge_strings(int argc, char *argv[] > sz += argc - start; > > buf = (char *)malloc(sizeof(char) * sz); > - bzero(buf, sizeof(char) * sz); > - > if (buf == NULL) { > sprintf(command_errbuf, "could not allocate space " > "for string"); > return (1); > } > + bzero(buf, sizeof(char) * sz); > > idx = 0; > for (i = start, idx = 0; i < argc; i++) { > Looks like a job for calloc(3) Cheers, Pedro.