From owner-freebsd-current@freebsd.org Sat Jan 21 01:31:32 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A1B3CB9177 for ; Sat, 21 Jan 2017 01:31:32 +0000 (UTC) (envelope-from lutungpin@openmailbox.org) Received: from lb1.openmailbox.org (lb1.openmailbox.org [5.79.108.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 522741A92 for ; Sat, 21 Jan 2017 01:31:32 +0000 (UTC) (envelope-from lutungpin@openmailbox.org) Received: by lb1.openmailbox.org (Postfix, from userid 20002) id E7A86525D7E; Sat, 21 Jan 2017 02:21:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1484961703; bh=Mm4ndRUeiVjI+6KPKZDzDWZYoTrCQ0N/FIFFNWf9/2s=; h=Date:From:To:Subject:From; b=r/Klq9fplhewl5JOaT79BK7RXktuwktPqJtu8drHCTA5ZopRubiOP1KPT8+G6xzvc taDqKsr7xd6Kj3Cf1b1eqmef+p9PWbYcfe2706mU6BQK59cr+JsHKUVefGELPzWhvg XkuagCqKIrxObRzJmuWB3kQGUwFQSkc/X/HwrCp4= Received: from www.openmailbox.org (unknown [10.0.0.3]) by lb1.openmailbox.org (Postfix) with ESMTP id 57A3F525BFF for ; Sat, 21 Jan 2017 02:21:42 +0100 (CET) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_4c8ece43f9a5623fa0f12896a365b95d" Date: Sat, 21 Jan 2017 01:21:42 +0000 From: Lu Tung-Pin To: freebsd-current@freebsd.org Subject: Fix /etc/rc.d/random umask handling (/entropy permissions) Message-ID: <14f5a2fdf191c33e4ed1dc882b288e81@openmailbox.org> X-Sender: lutungpin@openmailbox.org User-Agent: Roundcube Webmail/1.0.6 X-Mailman-Approved-At: Sat, 21 Jan 2017 02:01:31 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2017 01:31:32 -0000 --=_4c8ece43f9a5623fa0f12896a365b95d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed A 2014 change broke the umask handling in /etc/rc.d/random, leaving /entropy with ug+r permissions. Quick fix attached, mirroring random_stop() behavior. (Incidentally, /usr/libexec/save-entropy is still fine for /var/db/entropy/*, as is /etc/rc.d/random for the new /boot/entropy.) --- /etc/rc.d/random.old 2017-01-21 11:48:30.975009000 +1100 +++ /etc/rc.d/random 2017-01-19 18:04:34.224632000 +1100 @@ -20,12 +20,15 @@ save_dev_random() { + oumask=`umask` + umask 077 for f ; do if :>>"$f" ; then debug "saving entropy to $f" dd if=/dev/random of="$f" bs=4096 count=1 2>/dev/null fi done + umask ${oumask} } feed_dev_random() --=_4c8ece43f9a5623fa0f12896a365b95d Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=random.diff Content-Disposition: attachment; filename=random.diff; size=371 LS0tIC9ldGMvcmMuZC9yYW5kb20ub2xkCTIwMTctMDEtMjEgMTE6NDg6MzAuOTc1MDA5MDAwICsx MTAwCisrKyAvZXRjL3JjLmQvcmFuZG9tCTIwMTctMDEtMTkgMTg6MDQ6MzQuMjI0NjMyMDAwICsx MTAwCkBAIC0yMCwxMiArMjAsMTUgQEAKIAogc2F2ZV9kZXZfcmFuZG9tKCkKIHsKKwlvdW1hc2s9 YHVtYXNrYAorCXVtYXNrIDA3NwogCWZvciBmIDsgZG8KIAkJaWYgOj4+IiRmIiA7IHRoZW4KIAkJ CWRlYnVnICJzYXZpbmcgZW50cm9weSB0byAkZiIKIAkJCWRkIGlmPS9kZXYvcmFuZG9tIG9mPSIk ZiIgYnM9NDA5NiBjb3VudD0xIDI+L2Rldi9udWxsCiAJCWZpCiAJZG9uZQorCXVtYXNrICR7b3Vt YXNrfQogfQogCiBmZWVkX2Rldl9yYW5kb20oKQo= --=_4c8ece43f9a5623fa0f12896a365b95d--