From owner-svn-src-head@FreeBSD.ORG  Sun Nov 16 14:43:33 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 62DD8106564A;
	Sun, 16 Nov 2008 14:43:33 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 577118FC18;
	Sun, 16 Nov 2008 14:43:33 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mAGEhXaO055869;
	Sun, 16 Nov 2008 14:43:33 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id mAGEhXFO055868;
	Sun, 16 Nov 2008 14:43:33 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <200811161443.mAGEhXFO055868@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Sun, 16 Nov 2008 14:43:33 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r185000 - head/include
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2008 14:43:33 -0000

Author: ed
Date: Sun Nov 16 14:43:33 2008
New Revision: 185000
URL: http://svn.freebsd.org/changeset/base/185000

Log:
  Add a comment to utmp.h about the sizes of UT_HOSTSIZE and UT_LINESIZE.
  
  UT_HOSTSIZE and UT_LINESIZE are too small right now. If we ever bump
  UT_HOSTSIZE, we must not forget to increase UT_LINESIZE as well. If we
  add a comment, we're pretty sure we increase both values at the same
  time.
  
  PR:	bin/108743 (maybe others)

Modified:
  head/include/utmp.h

Modified: head/include/utmp.h
==============================================================================
--- head/include/utmp.h	Sun Nov 16 13:19:47 2008	(r184999)
+++ head/include/utmp.h	Sun Nov 16 14:43:33 2008	(r185000)
@@ -46,6 +46,13 @@
 #define	_PATH_WTMP	"/var/log/wtmp"
 #define	_PATH_LASTLOG	"/var/log/lastlog"
 
+/*
+ * XXX: These values are too low, but cannot be changed without breaking
+ * the file format.  Right now pts(4) is limited to 1000 instances,
+ * because /dev/pts/1000 would require UT_LINESIZE to be bigger.
+ * UT_HOSTSIZE is also too small to hold most common hostnames or IPv6
+ * addresses.
+ */
 #define	UT_NAMESIZE	16	/* see MAXLOGNAME in <sys/param.h> */
 #define	UT_LINESIZE	8
 #define	UT_HOSTSIZE	16