From owner-cvs-all Thu Jun 13 18:48:17 2002 Delivered-To: cvs-all@freebsd.org Received: from sdns.kv.ukrtel.net (sdns.kv.ukrtel.net [195.5.27.246]) by hub.freebsd.org (Postfix) with ESMTP id 62A5D37B425; Thu, 13 Jun 2002 18:48:08 -0700 (PDT) Received: from vega.vega.com (195.5.51.243 [195.5.51.243]) by sdns.kv.ukrtel.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id M2L7D6PP; Fri, 14 Jun 2002 04:50:10 +0300 Received: (from max@localhost) by vega.vega.com (8.11.6/8.11.3) id g5E1m5A10249; Fri, 14 Jun 2002 04:48:05 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) From: Maxim Sobolev Message-Id: <200206140148.g5E1m5A10249@vega.vega.com> Subject: Re: cvs commit: ports/Mk bsd.port.mk To: jmallett@FreeBSD.org (Juli Mallett) Date: Fri, 14 Jun 2002 04:48:05 +0300 (EEST) Cc: sobomax@FreeBSD.org (Maxim Sobolev), petef@absolutbsd.org (Pete Fritchman), trevor@jpj.net (Trevor Johnson), portmgr@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org In-Reply-To: <20020613183556.A76276@FreeBSD.ORG> from "Juli Mallett" at Jun 13, 2002 06:35:56 PM X-Mailer: ELM [version 2.5 PL5] MIME-Version: 1.0 Content-Type: text/plain; charset=DISPLAY Content-Transfer-Encoding: 8bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > * Maxim Sobolev escriurères > > > > > > * Pete Fritchman escriurères > > > > The addition of sed -i came when perl was removed. > > > > > > Wasn't it before? I forget now, it was ages ago in my mind. > > > > > > Anyway, it's on my list of things to MFC, but it was controversial when it was > > > on the tip of my mind, and I had trivial stuff I was having trouble getting to > > > the RELENG_4 branch during the freeze, so I decided I'd wait for the free for > > > all. I'd like to see ports move over to using it once it's been MFC'd for a > > > while... > > > > It was actually fortunate that it didn't go into 4.6 because I've just > > found and hopefully fixed one serious -i misbehaviour and one potential > > problem in sed(1). See commit logs for details. > > I went to great lengths to get review of my -i patches, including taking a > good deal of abuse for parts of them. I would have loved to have seen you > try to get some review too, since you say "hopefully fixed" and therefore > don't sound too sure of it. Well, I don't have a time for full-fledged review because the first problem with handling of multiple files would prevent me and others from doing REINPLACE_CMD sweep. I've tested it extensively here and don't plan to do MFC earlier than in 1-2 months, so that there will be plenty of time for testing. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message