From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Mar 28 02:30:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id AD20ECDE for ; Thu, 28 Mar 2013 02:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8E929FE for ; Thu, 28 Mar 2013 02:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2S2U0ha048336 for ; Thu, 28 Mar 2013 02:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2S2U0uF048335; Thu, 28 Mar 2013 02:30:00 GMT (envelope-from gnats) Resent-Date: Thu, 28 Mar 2013 02:30:00 GMT Resent-Message-Id: <201303280230.r2S2U0uF048335@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bryan Drewery Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E7F5DCA3 for ; Thu, 28 Mar 2013 02:25:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id BE0FCE1 for ; Thu, 28 Mar 2013 02:25:28 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2S2PSMx048226 for ; Thu, 28 Mar 2013 02:25:28 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2S2PSVS048225 for FreeBSD-gnats-submit@freebsd.org; Thu, 28 Mar 2013 02:25:28 GMT (envelope-from bdrewery) Received: (qmail 13818 invoked from network); 27 Mar 2013 21:25:25 -0500 Received: from unknown (HELO test8.xzibition.com) (10.10.0.34) by sweb.xzibition.com with SMTP; 27 Mar 2013 21:25:25 -0500 Received: by test8.xzibition.com (sSMTP sendmail emulation); Wed, 27 Mar 2013 21:25:24 -0500 Message-Id: <201303280225.r2S2PSVS048225@freefall.freebsd.org> Date: Wed, 27 Mar 2013 21:25:24 -0500 From: Bryan Drewery To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/177428: [PATCH] editors/emacs: missing INSTALLS_ICONS Cc: ashish@FreeBSD.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Bryan Drewery List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2013 02:30:00 -0000 >Number: 177428 >Category: ports >Synopsis: [PATCH] editors/emacs: missing INSTALLS_ICONS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Thu Mar 28 02:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Bryan Drewery >Release: FreeBSD 8.3-RELEASE-p5 i386 >Organization: >Environment: >Description: emacs, emacs-devel and emacs23 each install icons into share/icons/hicolor, but do not use INSTALLS_ICONS. This results in the cache not being built (so they are not usable), and creates a situation where the cache file is missing until another port is installed, so when that port is tested, the cache is seen as a leftover. See ports/170490 for example >How-To-Repeat: >Fix: Patch mirrored at http://people.freebsd.org/~bdrewery/emacs-icon-leftovers.txt Passing buildlogs at http://poudriere.shatow.net/bulk/83i386-dev-test/2013-03-27_20:11:30/logs/ --- emacs-icon-leftovers.txt begins here --- # svn status M editors/emacs/Makefile M editors/emacs-devel/Makefile M editors/emacs23/Makefile Index: editors/emacs/Makefile =================================================================== --- editors/emacs/Makefile (revision 315416) +++ editors/emacs/Makefile (working copy) @@ -30,6 +30,7 @@ USE_GMAKE= yes USE_NCURSES= yes USE_XZ= yes +INSTALLS_ICONS= yes CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib CONFIGURE_ARGS= --localstatedir=/var Index: editors/emacs-devel/Makefile =================================================================== --- editors/emacs-devel/Makefile (revision 315416) +++ editors/emacs-devel/Makefile (working copy) @@ -32,6 +32,7 @@ USE_GMAKE= yes USE_NCURSES= yes USE_XZ= yes +INSTALLS_ICONS= yes CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib CONFIGURE_ARGS= --localstatedir=/var Index: editors/emacs23/Makefile =================================================================== --- editors/emacs23/Makefile (revision 315416) +++ editors/emacs23/Makefile (working copy) @@ -31,6 +31,7 @@ USE_GMAKE= yes USE_BZIP2= yes USE_NCURSES= yes +INSTALLS_ICONS= yes CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib CONFIGURE_ARGS= --localstatedir=/var --- emacs-icon-leftovers.txt ends here --- >Release-Note: >Audit-Trail: >Unformatted: