From owner-freebsd-arch@FreeBSD.ORG Mon Feb 25 10:35:54 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E4BDF577 for ; Mon, 25 Feb 2013 10:35:54 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx1.freebsd.org (Postfix) with ESMTP id 53E92B62 for ; Mon, 25 Feb 2013 10:35:54 +0000 (UTC) Received: from mailout-de.gmx.net ([10.1.76.34]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0Mgr1C-1UVyUI139U-00M6zu for ; Mon, 25 Feb 2013 11:35:10 +0100 Received: (qmail invoked by alias); 25 Feb 2013 10:35:10 -0000 Received: from p5B131C70.dip.t-dialin.net (EHLO rotluchs.lokal) [91.19.28.112] by mail.gmx.net (mp034) with SMTP; 25 Feb 2013 11:35:10 +0100 X-Authenticated: #1673122 X-Provags-ID: V01U2FsdGVkX19KZOZxVUhKQPEdBYAeeJH51CoMBWTXsAiAgMoRQv xvAa2zejTSinSz Message-ID: <512B3E5C.2090506@gmx.de> Date: Mon, 25 Feb 2013 11:35:08 +0100 From: Christoph Mallon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130222 Thunderbird/17.0.3 MIME-Version: 1.0 To: Pawel Jakub Dawidek Subject: Re: Large Capsicum patch for review. References: <20130213025547.GA2025@garage.freebsd.pl> <20130213230221.GB1375@garage.freebsd.pl> <20130223221116.GR1377@garage.freebsd.pl> <5129ADC5.5040306@gmx.de> <20130224193058.GW1377@garage.freebsd.pl> In-Reply-To: <20130224193058.GW1377@garage.freebsd.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2013 10:35:55 -0000 On 24.02.2013 20:30, Pawel Jakub Dawidek wrote: > On Sun, Feb 24, 2013 at 07:05:57AM +0100, Christoph Mallon wrote: >> On 23.02.2013 23:11, Pawel Jakub Dawidek wrote: >>> On Thu, Feb 14, 2013 at 12:02:22AM +0100, Pawel Jakub Dawidek wrote: >>>> I'd like to commit this patch: >>>> >>>> http://people.freebsd.org/~pjd/patches/capkern.diff >>> >>> The patch was updated after the following changes and is available at >>> the link above: >> >> I was not able to apply this patch cleanly and had to fudge with the diff: >> - Two diff headers (contrib/openbsm/etc/audit_event and lib/libc/gen/Makefile.inc) have an extra space after --- and +++, which is recognized as part of the filename. >> Was this patch manually altered? > > Nope, but I'm using some script to generate patch(1)-compatbile diff > from a perforce diff. Ugh, why is p4 still in use, if it is just a hassle and hides history? >> - Two diffs (lib/libc/sys/cap_new.2 and sys/kern/uipc_mqueue.c) contain unexpanded $FreeBSD$ tags. >> I also had to guess, that the patch is to be applied onto r247201. >> I placed a cleaned up patch at http://tron.homeunix.org/zeug/FreeBSD/capsicum/0001-Capsicum-update.patch. >> >> This is a really big patch bomb changing lots of unrelated things. >> Do you have smaller, more managable diffs for easier review? > > I don't have smaller patch, unfortunately, but I don't think there are > unrelated things in there. Can you point me at them? The long list in your other email points out the unrealated stuff. Christoph