From owner-svn-src-all@freebsd.org Wed Sep 25 19:13:24 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 789C91301E5; Wed, 25 Sep 2019 19:13:24 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dnlR27dMz4LbB; Wed, 25 Sep 2019 19:13:23 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f67.google.com with SMTP id a1so1690892ioc.6; Wed, 25 Sep 2019 12:13:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8F9smyiez7GI1Ibot53O7iWeEYfbykqcc7leatNFeJc=; b=SuBEhedfX6e02ND70chsdtR43Q9kgZCdImya/nwlJXWW2qljABlLn8Ija8gcd1n52q ZWL0tHtHRExJZ+mPOKb4HmfZqK5wRbPK1sZUsJnc0DT+tsgBM+y1w6YnDaouF6Q1t4ST hIpsQ+lkVzh8XYBJrAhWDSyEJCPx6JwVTBE32kpUpSIuhaTzbvKXL/UM7Mu5dh4Kt8ik uJE0zKC0agZH1bCZ07kYMEl/2TsRU1iH9U12WxkTW5sJk+/XP+stDTXAfxlHjmn6ArV5 h0hwavWvyMoLLCgKBnczq5u+uhw/sO4HF4865CSoxhEfZL+nlEq6xShyHYA73oUnh/5K 9MOA== X-Gm-Message-State: APjAAAVsSt5A9iWnjma9B1loZs86xssgHpuODe2F9de4SJ3lwcut85Va ALlKRCams2/jCGD7Rn4Dpp7RwkMOGLv30DUb2+r+4Q== X-Google-Smtp-Source: APXvYqyhuEgsYV3wfL4hjDUs9aNUt/wKVRr7sovMuZj+uAG8QgP+3Zi4OwjLqWYEdIjZKX4OGgU4mWAG7TYLMYTG+oA= X-Received: by 2002:a6b:bb86:: with SMTP id l128mr1016804iof.18.1569438802186; Wed, 25 Sep 2019 12:13:22 -0700 (PDT) MIME-Version: 1.0 References: <201908210145.x7L1jU3x072180@repo.freebsd.org> <20190830140337.D1405@besplex.bde.org> In-Reply-To: <20190830140337.D1405@besplex.bde.org> From: Ed Maste Date: Wed, 25 Sep 2019 15:13:09 -0400 Message-ID: Subject: Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos To: Bruce Evans Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46dnlR27dMz4LbB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.67 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.42 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[67.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.42)[ip: (-1.59), ipnet: 209.85.128.0/17(-3.29), asn: 15169(-2.18), country: US(-0.05)]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; FREEMAIL_TO(0.00)[optusnet.com.au]; RWL_MAILSPIKE_POSSIBLE(0.00)[67.166.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2019 19:13:24 -0000 On Fri, 30 Aug 2019 at 00:29, Bruce Evans wrote: > > On Wed, 21 Aug 2019, Ed Maste wrote: > > > Author: emaste > > Date: Wed Aug 21 01:45:29 2019 > > New Revision: 351319 > > URL: https://svnweb.freebsd.org/changeset/base/351319 > > > > Log: > > makefs: use `char *` not `void *` for buf b_data, drop casts in msdos > > > > (The kernel uses caddr_t.) > > This is much better than churning the copy of the working code. My eventual goal is to converge on a shared copy of these files, generally moving to what is already done in the kernel's implementation. If there's reasonable clean up or improvements to be made in the kernel code I'm interested in doing so, but I'm not really sure what to do with the caddr_ts there yet. I see that NetBSD removed all uses of caddr_t.