From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:56 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B8930DD3CB; Tue, 3 Sep 2019 14:07:03 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N8072gbgz4QBr; Tue, 3 Sep 2019 14:07:03 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 046A51AFFE; Tue, 3 Sep 2019 14:06:27 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 5E6591CB54; Thu, 18 Apr 2019 01:07:32 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 292236D693; Thu, 18 Apr 2019 01:07:32 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 174501CB53; Thu, 18 Apr 2019 01:07:32 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 34C711CB50; Thu, 18 Apr 2019 01:07:29 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A19966D690; Thu, 18 Apr 2019 01:07:28 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x3I17QY7002946; Wed, 17 Apr 2019 18:07:26 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x3I17QDc002945; Wed, 17 Apr 2019 18:07:26 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201904180107.x3I17QDc002945@gndrsh.dnsmgr.net> Subject: Re: svn commit: r346341 - head/tools/build In-Reply-To: <201904180102.x3I120ms040287@repo.freebsd.org> To: Cy Schubert CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 292236D693 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:56 -0000 X-Original-Date: Wed, 17 Apr 2019 18:07:26 -0700 (PDT) X-List-Received-Date: Tue, 03 Sep 2019 14:07:56 -0000 > Author: cy > Date: Thu Apr 18 01:02:00 2019 > New Revision: 346341 > URL: https://svnweb.freebsd.org/changeset/base/346341 > > Log: > As an interim measure until a more permanent solution is implemented > workaround the following error: > > /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: use of > undeclared identifier > 'FA_OPEN' fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, FA_OPEN); > > Reported by: O. Hartmann > Reported by: Michael Butler > Reported by: gjb@ & cy@ (implicit) > Reviewed by: emaste@ > Noted by: rgrimes@ > > Modified: > head/tools/build/Makefile > > Modified: head/tools/build/Makefile > ============================================================================== > --- head/tools/build/Makefile Thu Apr 18 00:38:54 2019 (r346340) > +++ head/tools/build/Makefile Thu Apr 18 01:02:00 2019 (r346341) > @@ -59,9 +59,7 @@ INCS+= capsicum_helpers.h > INCS+= libcasper.h > .endif > > -.if !exists(/usr/include/casper/cap_fileargs.h) > CASPERINC+= ${SRCTOP}/lib/libcasper/services/cap_fileargs/cap_fileargs.h > -.endif As a further note, we should probably hunt for any thing that is explicity looking at /usr/include/... in a Makefile, as that is minimally missing a ${DESTDIR} argument. The above may of actually worked if it had been written: .if !exists(${DESTDIR}/usr/include/casper/cap_fileargs.h) someone may wish to test that. Also a pathname rooted at / without ${DESTDIR} is almost certainly a mistake. > .if empty(SRCS) > SRCS= dummy.c -- Rod Grimes rgrimes@freebsd.org