From owner-cvs-src@FreeBSD.ORG  Sat Mar 12 05:06:53 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0262916A4CE; Sat, 12 Mar 2005 05:06:53 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 48A4043D31; Sat, 12 Mar 2005 05:06:50 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j2C57SrH096806;
	Fri, 11 Mar 2005 22:07:28 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <4232785A.5050805@samsco.org>
Date: Fri, 11 Mar 2005 22:04:26 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maxime Henrion <mux@FreeBSD.org>
References: <200503120243.j2C2hoki067520@repoman.freebsd.org>
In-Reply-To: <200503120243.j2C2hoki067520@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Mar 2005 05:06:53 -0000

Maxime Henrion wrote:
> mux         2005-03-12 02:43:50 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/alpha/alpha      busdma_machdep.c 
>   Log:
>   Fix a long-standing bug in alpha's implementation of busdma.  We need to
>   OR the physical address with alpha_XXX_dmamap_or to get the DMA address,
>   like the name of the variable suggests.  However, while we were doing
>   this correctly in the alpha_XXX_dmamap() macro, the busdma code added
>   the variable to the physical address instead of or'ing it.  Fortunately
>   and if my math is not entirely wrong, you would need more than 128GB of
>   RAM and a device able to do DMA in 64bits to experience the bug.
>   
>   Spotted by:     cognet
>   
>   Revision  Changes    Path
>   1.50      +4 -4      src/sys/alpha/alpha/busdma_machdep.c

You're aware that we don't correctly support the Alpha IOMMU, so we are 
limited to 2GB or so of physical RAM anyways.

Scott