From owner-cvs-all@FreeBSD.ORG Wed Apr 30 07:31:24 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4720537B401; Wed, 30 Apr 2003 07:31:24 -0700 (PDT) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9C0643FA3; Wed, 30 Apr 2003 07:31:22 -0700 (PDT) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id D94ED1B211; Wed, 30 Apr 2003 15:31:21 +0100 (BST) Date: Wed, 30 Apr 2003 15:31:21 +0100 From: Paul Richards To: Kris Kennaway Message-ID: <20030430143121.GK39658@survey.codeburst.net> References: <20030430002014.GA1190@dragon.nuxi.com> <20030430043303.GA46365@mero.morphisms.net> <20030430062647.GA82023@rot13.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030430062647.GA82023@rot13.obsecurity.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: "W. Josephson" cc: cvs-all@FreeBSD.org cc: Daniel Eischen Subject: Re: cvs commit: src/lib/libc/gen check_utility_compat.c confstr.c un-namespace.hgethostbydns.c getnameinfo.c hesiod.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2003 14:31:25 -0000 On Tue, Apr 29, 2003 at 11:26:47PM -0700, Kris Kennaway wrote: > On Wed, Apr 30, 2003 at 12:33:03AM -0400, W. Josephson wrote: > > On Wed, Apr 30, 2003 at 12:27:22AM -0400, Daniel Eischen wrote: > > > Why can't you still do this? You just have to know the real > > > name of the function you want to override. Is malloc any > > > different than _malloc, so that you can't supply your own > > > with the correct symbol? > > > > It is just one more thing to hack around on > > every platform. I still don't understand > > why the urge to make things more complicated > > for the sake of admittedly broken software. > > Why not just fix the bug at its source rather > > than making life more difficult for stuff that > > is written correctly? > > Because the source is not always available. Fortunately, for qpopper > it is, but as Jacques stated in another message there is a chance that > other binary applications also do this. Hiding our libc implementation is the wrong approach here. I think the strlcpy hiding should be taken out. Your example of binary only applications actually shows exactly why this approach is wrong since if the application deliberately tries to override the libc version then it won't work. If it's a bug in the application then it's a bug in the application and either that gets fixed in the source or you complain to the vendor.Messing with the exported symbols from libc doesn't seem like the right solution to me. -- Paul Richards