Date: Sun, 1 Sep 2013 20:04:51 GMT From: Gerald Pfeifer <gerald@pfeifer.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/181730: ports-mgmt/portlint: don't stop checks for COMMENT after first warning Message-ID: <201309012004.r81K4p0S001944@ref10-i386.freebsd.org> Resent-Message-ID: <201309012010.r81KA1we016324@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181730
>Category: ports
>Synopsis: ports-mgmt/portlint: don't stop checks for COMMENT after first warning
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 01 20:10:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer
>Release:
>Organization:
>Environment:
>Description:
Currently portlint stops checking for further issues once
the first has been found for the COMMENT field in Makefile.
>How-To-Repeat:
Make COMMENT$of some test port read "a1234567890123456789012345678901234567890123456789012345678901234567890".
Run portlint.
See how there is no complaint about the length of the COMMENT.
>Fix:
--- portlint.pl.orig 2013-07-16 12:35:28.823262000 +0000
+++ portlint.pl 2013-09-01 19:59:38.228589000 +0000
@@ -2839,7 +2839,8 @@
} else { # check for correctness
if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
- } elsif (length($makevar{COMMENT}) > 70) {
+ }
+ if (length($makevar{COMMENT}) > 70) {
&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
}
}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309012004.r81K4p0S001944>