From owner-svn-ports-all@freebsd.org  Mon Sep  3 19:19:21 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B62DFF3541;
 Mon,  3 Sep 2018 19:19:21 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1E35572D03;
 Mon,  3 Sep 2018 19:19:21 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 16C0119608; Mon,  3 Sep 2018 19:19:21 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: "George V. Neville-Neil" <gnn@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r478889 - in head/comms/libbtbb: . files
References: <201809031835.w83IZPPN007055@repo.freebsd.org>
Date: Mon, 03 Sep 2018 21:19:12 +0200
In-Reply-To: <201809031835.w83IZPPN007055@repo.freebsd.org> (George
 V. Neville-Neil's message of "Mon, 3 Sep 2018 18:35:25 +0000 (UTC)")
Message-ID: <sh2q-crtb-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Sep 2018 19:19:21 -0000

"George V. Neville-Neil" <gnn@FreeBSD.org> writes:

> +PORTVERSION=	201808R1
[...]
> +GH_TAGNAME=	2018-08-R1

Try replacing both with DISTVERSION=2018-08-R1 then re-run "make makesum".

> +BUILD_DEPENDS=	python27:lang/python27 \

USES=python:2.7,build or USES=python:build as it builds fine with Python 3.6.
As is the build is broken, see https://ptpb.pw/lsN0

> +		pyside-py27:devel/pyside \

pyside${PYTHON_PKGNAMESUFFIX}>0:devel/pyside@${PY_FLAVOR} but ...

> +		${PYNUMPY}

... are these actually used?

$ make clean patch BATCH=
$ fgrep -ril -e pyside -e numpy `make -V WRKSRC`

> + A Bluetooth baseband decoding library
>
> +This is a Bluetooth baseband decoding library.

Better move "decoding" to COMMENT then rephrase the rest to be less tautological.

> +bin/btaptap

$ echo DEVELOPER=1 >>${__MAKE_CONF:-/etc/make.conf}
$ make stage-qa
[...]
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/btaptap'

> +lib/libbtbb.so
> +lib/libbtbb.so.1
> +lib/libbtbb.so.1.0

$ portlint -C
WARN: pkg-plist: [3]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: pkg-plist: [4]: installing shared libraries, please define USE_LDCONFIG as appropriate
0 fatal errors and 2 warnings found.