From owner-svn-src-head@freebsd.org Sat Mar 23 18:56:45 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D1721559B36 for ; Sat, 23 Mar 2019 18:56:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A626C770E9 for ; Sat, 23 Mar 2019 18:56:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x831.google.com with SMTP id t28so6175556qte.6 for ; Sat, 23 Mar 2019 11:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/igzfUg9M8WyLVUiAKD++xznXpJyk2lOJ2lC6pjBKlI=; b=b7eAHvIbmffv/Vj1fFaLQxMSOnJlY4mXbmiUzMPHYXJbnOyktcM1ecP5kuztUNpjOR DMRmb6pUD6d6R9ynRzwy4vich3lc1j8nFpBELcPflMQ6nvXKKTgNzVnozSiWDzlWVWRg m3hGlHwhacffvPsfoGMDsatPcEoUrMPJAGAouQ/amebyw/Ai+9MOxSI+KNuQOyyKu9f+ Upi5BNWIStl7WzODBZjCjnqwv2jNdSef7zEiC9tcOczMTgRjUaOPgAYis/pZV7kNSDjO w8RpsTE5WI43qhBpqB+pHsaJ5pGD4Nl2ieKIZecwttySMKE+gdXAAh0koHZwkBUuxvV7 ZGNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/igzfUg9M8WyLVUiAKD++xznXpJyk2lOJ2lC6pjBKlI=; b=Nm6eeqX9JILt+mBv9gXJHyrRt2IzwlPJXOt3Ut5Z1E+RNfgKWA76fuGjlObBlSFuas 1G5SP7tHbVePk/byzDa2HXhY8erh1XQ5zcHCPqBrv1bUt1kws2wCODy/D8mbW1NKhnac 2Qs/f0ENrd46NY8JerEYezHIvGP8NjNHTyAM+2b/hpxHHGsfTMqJlj4VT1n0zuI30Bfv Q74LViLdSJLX5msXd1IQpRmJovrzjeqfp5XFRR+lcPFfsciQ6XUC/SucZ4dZr/kEzios i0QczAC8Wq3Jwr63AsBAWD/MYYZBBRiW+vkgwZHK4CO20gXzfA+gxD1TTp8DovdADmEV pbAw== X-Gm-Message-State: APjAAAU6jd2umF0eTsoGV3MN0c448onSoyNJ/BQxf17f+DookilPQX6V u8Fe4zBWvnTUdO/6C+yK4VRniOejiHgSgJGllX7IOA== X-Google-Smtp-Source: APXvYqzzFu8fi2Y/mZe+xIgNQAzk39r/P3D5ItOt12HBrwihBs8KwVtj0gqbhiELsEX2PemKYkWR2hEppyKWIJzhjGQ= X-Received: by 2002:ac8:2b2e:: with SMTP id 43mr13835441qtu.33.1553367404042; Sat, 23 Mar 2019 11:56:44 -0700 (PDT) MIME-Version: 1.0 References: <201903231832.x2NIWODK045636@repo.freebsd.org> <20190323185332.GN1923@kib.kiev.ua> In-Reply-To: <20190323185332.GN1923@kib.kiev.ua> From: Warner Losh Date: Sat, 23 Mar 2019 12:56:33 -0600 Message-ID: Subject: Re: svn commit: r345455 - head/sys/mips/conf To: Konstantin Belousov Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: A626C770E9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.944,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Mar 2019 18:56:45 -0000 On Sat, Mar 23, 2019 at 12:53 PM Konstantin Belousov wrote: > On Sat, Mar 23, 2019 at 06:32:24PM +0000, Warner Losh wrote: > > Author: imp > > Date: Sat Mar 23 18:32:24 2019 > > New Revision: 345455 > > URL: https://svnweb.freebsd.org/changeset/base/345455 > > > > Log: > > Add device xz. This was somehow missed in the last round. > Because the config has #NO_UNIVERSE comment. > That's a flaw in the NO_UNIVERSE comment. We have dozens of kernels that are mostly useless to build most of the time... except for the exact change you made where you really did want to build them all to make sure.... :( I'll hack together something to allow testing everything and fix what might be broken. A FreeBSD user reported this to me. Thanks for the explanation... I didn't mean to cast any aspersions with what I see now as a poorly worded commit message... Warner > > > > Submitted by: Brandon Bergren > > > > Modified: > > head/sys/mips/conf/DIR-825C1 > > > > Modified: head/sys/mips/conf/DIR-825C1 > > > ============================================================================== > > --- head/sys/mips/conf/DIR-825C1 Sat Mar 23 16:46:33 2019 > (r345454) > > +++ head/sys/mips/conf/DIR-825C1 Sat Mar 23 18:32:24 2019 > (r345455) > > @@ -44,6 +44,7 @@ device geom_map > > # uzip - to boot natively from flash > > options GEOM_UZIP > > options GEOM_PART_GPT > > +device xz > > > > # yes, this board has a PCI connected atheros device > > options AR71XX_ATH_EEPROM >