Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Mar 2019 12:56:33 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r345455 - head/sys/mips/conf
Message-ID:  <CANCZdfo2zAMtWF1bmhrsxdOL8Yt5CDMR3uzyirG54maR27rKew@mail.gmail.com>
In-Reply-To: <20190323185332.GN1923@kib.kiev.ua>
References:  <201903231832.x2NIWODK045636@repo.freebsd.org> <20190323185332.GN1923@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 23, 2019 at 12:53 PM Konstantin Belousov <kostikbel@gmail.com>
wrote:

> On Sat, Mar 23, 2019 at 06:32:24PM +0000, Warner Losh wrote:
> > Author: imp
> > Date: Sat Mar 23 18:32:24 2019
> > New Revision: 345455
> > URL: https://svnweb.freebsd.org/changeset/base/345455
> >
> > Log:
> >   Add device xz. This was somehow missed in the last round.
> Because the config has #NO_UNIVERSE comment.
>

That's a flaw in the NO_UNIVERSE comment. We have dozens of kernels that
are mostly useless to build most of the time... except for the exact change
you made where you really did want to build them all to make sure.... :(

I'll hack together something to allow testing everything and fix what might
be broken. A FreeBSD user reported this to me. Thanks for the
explanation... I didn't mean to cast any aspersions with what I see now as
a poorly worded commit message...

Warner


> >
> >   Submitted by: Brandon Bergren
> >
> > Modified:
> >   head/sys/mips/conf/DIR-825C1
> >
> > Modified: head/sys/mips/conf/DIR-825C1
> >
> ==============================================================================
> > --- head/sys/mips/conf/DIR-825C1      Sat Mar 23 16:46:33 2019
> (r345454)
> > +++ head/sys/mips/conf/DIR-825C1      Sat Mar 23 18:32:24 2019
> (r345455)
> > @@ -44,6 +44,7 @@ device          geom_map
> >  # uzip - to boot natively from flash
> >  options      GEOM_UZIP
> >  options         GEOM_PART_GPT
> > +device               xz
> >
> >  # yes, this board has a PCI connected atheros device
> >  options         AR71XX_ATH_EEPROM
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo2zAMtWF1bmhrsxdOL8Yt5CDMR3uzyirG54maR27rKew>