From owner-freebsd-usb@FreeBSD.ORG Sun Aug 24 05:10:43 2008 Return-Path: Delivered-To: usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F73B106567A; Sun, 24 Aug 2008 05:10:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id A69688FC1A; Sun, 24 Aug 2008 05:10:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m7O5AO8b010004; Sat, 23 Aug 2008 23:10:24 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 23 Aug 2008 23:10:58 -0600 (MDT) Message-Id: <20080823.231058.-1605553760.imp@bsdimp.com> To: fbsd-current@mawer.org From: "M. Warner Losh" In-Reply-To: <48B0EA50.2090105@mawer.org> References: <48ABB1FA.5070609@mawer.org> <48AFE196.7050100@vwsoft.com> <48B0EA50.2090105@mawer.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: volker@vwsoft.com, usb@freebsd.org, current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: HEADSUP new usb code coming in. X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 05:10:43 -0000 In message: <48B0EA50.2090105@mawer.org> Antony Mawer writes: : On 23/08/2008 8:08 PM, Volker wrote: : > On 12/23/-58 20:59, Antony Mawer wrote: : >> M. Warner Losh wrote: : >>> In message: <48AB566B.5010507@mawer.org> : >>> Antony Mawer writes: : >>> : Warner Losh wrote: : >>> : > From: Bakul Shah : >>> : > Subject: Re: HEADSUP new usb code coming in. : > Date: Tue, 19 Aug : >>> 2008 14:18:13 -0700 : >>> : > : >> On Tue, 19 Aug 2008 22:44:20 +0200 Hans Petter Selasky : >>> wrote: : >>> : >>> New stuff (all of which I can remember right now): : >>> : >> ... : >>> : >> : >>> : >> Accidentally unplugging a mounted USB disk (without : >>> : >> unmounting it) resulted in a hang or a crash. Is this fixed? : >>> : > : > That's fixed in -current right now with the old stack. It : >>> isn't a usb : >>> : > issue at all, but a buffer cache issue. : >>> : : Is this change that is likely to be MFC'd in time for 7.1? And/or : >>> is : there a specific patch that can manually be applied to -STABLE to : >>> fix this? : >>> : >>> I should spend the time to dig into the changes in current. There : >>> turned out to be several little changes... And I need to verify all : >>> the edge cases were covered... : >> I'd be happy to test patches if you do end up doing this.. it would be : >> really nice to have in 7.1, or at least available as a patchset if it : >> isn't suitable for MFC (eg. ABI changes)... : > : > I'm a bit behind with reading emails. Please forgive me if this has : > already been answered. : > : > Don't expect the new USB stack for 7.1-R. It's too short and the new USB : > stack will introduce an ABI breakage. For that, all drivers written for : > the old USB stack need to be rewritten and I guess, we need to take care : > about 3rd party developers and inform them in advance about that massive : > change. I would not wonder if this will never get MFC'd but I don't know : > actually. : : This wasn't about the new USB stack -- we were discussing the buffer : cache and CAM-related fixes that prevents the system from panic'ing when : a USB device is unplugged without first unmounting the filesystem. These : patches are in HEAD with the existing USB stack. :-) The best I can do is say "Maybe" and the answer is closer to yes if somebody data-mines the changes I've made in this area in -current. That's the hard part of back porting them.. Warner