From owner-dev-commits-src-branches@freebsd.org Sat Mar 6 09:36:36 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7212A55F132; Sat, 6 Mar 2021 09:36:36 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "vtr.rulingia.com", Issuer "R3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DszyC2qR6z3N6k; Sat, 6 Mar 2021 09:36:31 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.16.1/8.15.2) with ESMTPS id 1269aNOc066892 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 6 Mar 2021 20:36:28 +1100 (AEDT) (envelope-from peter@rulingia.com) DKIM-Filter: OpenDKIM Filter v2.10.3 vtr.rulingia.com 1269aNOc066892 X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.16.1/8.16.1) with ESMTPS id 1269aHsg039531 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 6 Mar 2021 20:36:18 +1100 (AEDT) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.16.1/8.16.1/Submit) id 1269aHgI039530; Sat, 6 Mar 2021 20:36:17 +1100 (AEDT) (envelope-from peter) Date: Sat, 6 Mar 2021 20:36:17 +1100 From: Peter Jeremy To: Oleksandr Tymoshenko Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: f76393a6305b - stable/13 - armv8crypto: add AES-GCM support Message-ID: References: <202101230635.10N6Zf9L012423@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3AtvwTlPa3p/4zAP" Content-Disposition: inline In-Reply-To: <202101230635.10N6Zf9L012423@gitrepo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp X-Rspamd-Queue-Id: 4DszyC2qR6z3N6k X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.10 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[rulingia.com:s=default]; FREEFALL_USER(0.00)[peter]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2001:19f0:5801:ebe:5400:1ff:fe53:30fd:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[rulingia.com:+]; DMARC_POLICY_ALLOW(-0.50)[rulingia.com,quarantine]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:19f0:5801:ebe:5400:1ff:fe53:30fd:from]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-branches,dev-commits-src-all] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 09:36:36 -0000 --3AtvwTlPa3p/4zAP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Jan-23 06:35:41 +0000, Oleksandr Tymoshenko wro= te: >The branch stable/13 has been updated by gonzo: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3Df76393a6305b67c0f3439ba684c= 5d49a2aafe2a0 > >commit f76393a6305b67c0f3439ba684c5d49a2aafe2a0 >Author: Oleksandr Tymoshenko >AuthorDate: 2021-01-13 06:27:10 +0000 >Commit: Oleksandr Tymoshenko >CommitDate: 2021-01-23 06:34:37 +0000 > > armv8crypto: add AES-GCM support > =20 > Add support for AES-GCM using OpenSSL's accelerated routines. This breaks geli using AES-XTS 128. I have a geli partition last written on 12-stable about a year ago. I can read it successfully on a RockPro64 (RK3399) running 13.0-ALPHA2 (c256201-g02611ef8ee9) but it fails on 13.0-BETA4 (releng/13.0-n244592-e32bc253629) as well as releng/13.0 60e8939aa85b and main 028616d0dd69. If I start with releng/13.0 60e8939aa85b and revert f76393a6305b, the problem goes away. By "fail": geli attaches without issue but the .eli device returns garbage (though the garbage is consistent between reboots). --=20 Peter Jeremy --3AtvwTlPa3p/4zAP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmBDTRFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzTDfA//RsGsPQIl42ll++Q4pJugOvVFsfET8J4T0bCX5x5gtU1592oriis3qDZp zVx4VvIZphUryy7hoYLjN3BKpFnlz8BY+RJOIXreRBzT8AQgXRLSHSNs58/hQJCs FO+DQnOkSTdC4rPn1sCnqQuJUhv8+wiK4FnPCq4mNM2BxNa4D710XV0zYFFRBlAJ xVFLYa2Uuf0mmhq8LSFUXlEGgdesYANJ1420IwUBv5lAFxRHn+6SM3jLtDK9OQQV h5OC9bPPRuekqtvpA0RUXzfWf5zKMqaTvufdAOaYA2ct+7A1bEsCOe9HFlKeIHUm fTXOh6f0PHY5Vtp5bBqZL+aDFEzpHkMAi19zKYRKR7kYlwy7vJHd4DBUJJLTlLE8 JpAAQO/r0oA6I3AsdekF9uRHChZko4Hq9dtRgKtimTr1kXZWLTV9ISDmshn9SZZn Cb5EXr6Ky3PUrNifgOd/3WnSDFvXXBERkXw3er9I5TGup2SoSj/6jX3iaRGjWiGv fBNKPV7+mGAX4MuK2E5PZUQbGgo73hvECVGiI654yvYivfpSmEFeXuxi5vqCz696 rDt3qYrc4lNYjqTpy92NlKmSs0G9btGqYtICkK3soDSFAF+Cwhv3hMjLrxZMEZXC H/f2ynnMqeTGe65USA00P8KWCWAcUEFBVb4eR9D7rb3qz/Tdlsk= =eC4u -----END PGP SIGNATURE----- --3AtvwTlPa3p/4zAP--