Date: Wed, 20 Sep 2000 12:10:02 -0700 (PDT) From: Will Andrews <will@physics.purdue.edu> To: freebsd-ports@FreeBSD.org Subject: Re: ports/21425: Perl5 module, port submission (converters/p5-Unicode-Map8) Message-ID: <200009201910.MAA18103@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/21425; it has been noted by GNATS.
From: Will Andrews <will@physics.purdue.edu>
To: ilia@jane.cgu.chel.su
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/21425: Perl5 module, port submission (converters/p5-Unicode-Map8)
Date: Wed, 20 Sep 2000 13:59:19 -0500
On Wed, Sep 20, 2000 at 11:42:59PM +0600, ilia@jane.cgu.chel.su wrote:
> >Synopsis: Perl5 module, port submission (converters/p5-Unicode-Map8)
Thanks for your submission; I'll be committing shortly. But be careful
with uuencoded files:
> begin 644 p5-Unicode-Map8.tar
[..snip..]
> M````````````````````````````````````````````````````````````
> M````````````````````````````````````````````````````````````
> M````````````````````````````````````````````````````````````
> M````````````````````````````````````````````````````````````
> M````````````````````````````````````````````````````````````
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> >````````````````````````````````````````
> `
> end
As you can see, GNATS cut some of the uuencoding off near the bottom,
and this results in a missing Makefile in the tarball. If problems like
this happen often with you, I suggest just posting a pointer at the
tarball on the web somewhere.
Also, while reviewing your port, I found that the header was missing
from the Makefile (could be because of the truncated uuencoding). So I
added the default, which includes your name.
You also had two BUILD_DEPENDS that simply look for different files
originating from the same port. That's gratuitous, and should be
avoided. Also, the long lines as a result of site_perl etc. I shortened
by consolidating the common directories in a ${SITE_PERL} variable.
Another thing I noticed is that your port does not make the Perl
Makefile respect CFLAGS. So I fixed that too (I think I noticed
converters/p5-Unicode-String doesn't respect it either).
--
Will Andrews <will@physics.purdue.edu> <will@FreeBSD.org>
GCS/E/S @d- s+:+ a--- C++ UB++++$ P+ L- E--- W+ N-- !o ?K w---
O- M+ V- PS+ PE++ Y+ PGP+>+++ t++ 5 X+ R+ tv+ b++ DI+++ D+
G++ e>++++ h! r- y?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009201910.MAA18103>