From owner-freebsd-ports@FreeBSD.ORG Wed Dec 24 02:29:58 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 203581065673; Wed, 24 Dec 2008 02:29:58 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.242]) by mx1.freebsd.org (Postfix) with ESMTP id A34C88FC18; Wed, 24 Dec 2008 02:29:57 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by an-out-0708.google.com with SMTP id c2so1229937anc.13 for ; Tue, 23 Dec 2008 18:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:references:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:x-mailer :mime-version:subject:date:cc; bh=plrOEz4NpDJYKr4lsiUhHbhzc9we36ynPmEIQwY/OSM=; b=xZLDI1sGJsZJuPbvp2yxCyZs86Ib9q9SbBnJrEJj0FT8hF8DYENS6XOQfSG45KyP4F nGbWLlAufGfwE9khFgpoT1zEQUVw1JB0rtV3njv+qnGEGEkfBo7FW9Uezoj34j4xeH9t dfzdRhIM2Be+x5ZRfmlzWinHdctBhIu0Jaiww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=references:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:x-mailer:mime-version:subject:date:cc; b=mDQwUAzb9P/rddbURHssCHxp56M79j+S9dJACx9oWtuJd08H3pZF0Urr31BD0WQsVQ 1mUBnGTw2zYZDVvWXWKx9Oir1kPfMJK0bDpbdW5eI8tlC6LwlJC0+/5jQkxg4EhoXBiG 7Z1wSlj0nU1CL+7D0Gw2BAw4XWooMMNc+9qAk= Received: by 10.100.143.12 with SMTP id q12mr5058744and.22.1230085796511; Tue, 23 Dec 2008 18:29:56 -0800 (PST) Received: from ?10.84.67.166? ([32.154.190.237]) by mx.google.com with ESMTPS id b32sm13852652ana.34.2008.12.23.18.29.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 23 Dec 2008 18:29:55 -0800 (PST) References: <49504D4B.8040402@gmail.com> <49515A77.3050204@FreeBSD.org> <49517DB4.1060704@gmail.com> Message-Id: <2DD9A4BD-EFFF-482F-90DA-F9078229539A@gmail.com> From: Garrett Cooper To: Eitan Adler In-Reply-To: <49517DB4.1060704@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: iPhone Mail (5F136) Mime-Version: 1.0 (iPhone Mail 5F136) Date: Tue, 23 Dec 2008 18:29:45 -0800 Cc: "ports@freebsd.org" , Doug Barton Subject: Re: proposal: add --disable-tests to www/firefox3 port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2008 02:29:58 -0000 On Dec 23, 2008, at 16:09, Eitan Adler wrote: >>> Perhaps this could be part of the WITH_DEBUG option? > Like this? > --- firefox3/Makefile 2008-12-19 15:13:01.000000000 -0500 > +++ firefox-new/Makefile 2008-12-23 19:07:09.000000000 -0500 > @@ -57,6 +57,10 @@ > > .include > > +.if defined(WITHOUT_DEBUG) > +MOZ_OPTIONS+= --disable-tests > +.endif > + > GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg: > %{pthread:' | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || $ > {TRUE} > > Also > WARN: Makefile: [SMB is listed in OPTIONS, but neither WITH_SMB nor > WITHOUT_SMB appears.]: > WARN: Makefile: [LOGGING is listed in OPTIONS, but neither > WITH_LOGGING > nor WITHOUT_LOGGING appears.]: > WARN: Makefile: [OPTIMIZED_CFLAGS is listed in OPTIONS, but neither > WITH_OPTIMIZED_CFLAGS nor WITHOUT_OPTIMIZED_CFLAGS appears.]: > > Are they used at all? should they just be removed? > > -- > Eitan Adler > GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 Looks good. The suggestion to remove those flags first warrants checking the mozilla include makefile. Cheers, -Garrett