From owner-freebsd-bugs@FreeBSD.ORG  Fri Dec 23 02:00:30 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F5D91065691
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 23 Dec 2011 02:00:30 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 192FA8FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 23 Dec 2011 02:00:30 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBN20TPk054123
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 23 Dec 2011 02:00:29 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBN20TRO054110;
	Fri, 23 Dec 2011 02:00:29 GMT (envelope-from gnats)
Date: Fri, 23 Dec 2011 02:00:29 GMT
Message-Id: <201112230200.pBN20TRO054110@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/83348: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2011 02:00:30 -0000

The following reply was made to PR bin/83348; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/83348: commit references a PR
Date: Fri, 23 Dec 2011 01:56:39 +0000 (UTC)

 Author: ghelmer
 Date: Fri Dec 23 01:56:25 2011
 New Revision: 228826
 URL: http://svn.freebsd.org/changeset/base/228826
 
 Log:
   Handle failures to malloc memory to hold key or val copies.
   
   PR:		bin/83348
 
 Modified:
   head/lib/libc/yp/xdryp.c
 
 Modified: head/lib/libc/yp/xdryp.c
 ==============================================================================
 --- head/lib/libc/yp/xdryp.c	Fri Dec 23 01:39:10 2011	(r228825)
 +++ head/lib/libc/yp/xdryp.c	Fri Dec 23 01:56:25 2011	(r228826)
 @@ -82,10 +82,21 @@ xdr_ypresp_all_seq(XDR *xdrs, u_long *ob
  		switch (status) {
  		case YP_TRUE:
  			key = (char *)malloc(out.ypresp_all_u.val.key.keydat_len + 1);
 +			if (key == NULL) {
 +				xdr_free((xdrproc_t)xdr_ypresp_all, &out);
 +				*objp = YP_YPERR;
 +				return (FALSE);
 +			}
  			bcopy(out.ypresp_all_u.val.key.keydat_val, key,
  				out.ypresp_all_u.val.key.keydat_len);
  			key[out.ypresp_all_u.val.key.keydat_len] = '\0';
  			val = (char *)malloc(out.ypresp_all_u.val.val.valdat_len + 1);
 +			if (val == NULL) {
 +				free(key);
 +				xdr_free((xdrproc_t)xdr_ypresp_all, &out);
 +				*objp = YP_YPERR;
 +				return (FALSE);
 +			}
  			bcopy(out.ypresp_all_u.val.val.valdat_val, val,
  				out.ypresp_all_u.val.val.valdat_len);
  			val[out.ypresp_all_u.val.val.valdat_len] = '\0';
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"