From owner-svn-src-head@freebsd.org Fri Nov 4 17:08:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB426C304C0; Fri, 4 Nov 2016 17:08:53 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9D758EF7; Fri, 4 Nov 2016 17:08:53 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id uA4H8q3m032529; Fri, 4 Nov 2016 17:08:52 GMT (envelope-from scottl@FreeBSD.org) Received: (from scottl@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id uA4H8qcc032528; Fri, 4 Nov 2016 17:08:52 GMT (envelope-from scottl@FreeBSD.org) Message-Id: <201611041708.uA4H8qcc032528@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: scottl set sender to scottl@FreeBSD.org using -f From: Scott Long Date: Fri, 4 Nov 2016 17:08:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r308299 - head/sys/cam/scsi X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 17:08:53 -0000 Author: scottl Date: Fri Nov 4 17:08:52 2016 New Revision: 308299 URL: https://svnweb.freebsd.org/changeset/base/308299 Log: If the da periph probe state machine gets an asc=0x44 error, the periph is not going to recover until the system is reset. Treat it as a special case and don't allow it to fall through to quasi-success. Reviewed by: ken, imp Obtained from: Netflix MFC after: 3 days Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c ============================================================================== --- head/sys/cam/scsi/scsi_da.c Fri Nov 4 17:04:45 2016 (r308298) +++ head/sys/cam/scsi/scsi_da.c Fri Nov 4 17:08:52 2016 (r308299) @@ -4310,8 +4310,14 @@ dadone(struct cam_periph *periph, union * direct access or optical disk device, * as long as it doesn't return a "Logical * unit not supported" (0x25) error. + * "Internal Target Failure" (0x44) is also + * special and typically means that the + * device is a SATA drive behind a SATL + * translation that's fallen into a + * terminally fatal state. */ - if ((have_sense) && (asc != 0x25) + if ((have_sense) + && (asc != 0x25) && (asc != 0x44) && (error_code == SSD_CURRENT_ERROR)) { const char *sense_key_desc; const char *asc_desc;