From owner-cvs-all@FreeBSD.ORG Sat Aug 7 19:51:51 2010 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3656A1065670; Sat, 7 Aug 2010 19:51:51 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 6FE728FC0A; Sat, 7 Aug 2010 19:51:49 +0000 (UTC) Received: by wwb13 with SMTP id 13so1103979wwb.31 for ; Sat, 07 Aug 2010 12:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=PYr5CUi+y4ERxswA4+mdH+R1MPcWUUC5I9CDxCH33WU=; b=RpKdZ4s0LLoIB8hBSYLJhBnVF3jvK+57p0xZHMMmXd5KuvEK81jY6ujtefuBnkTGNg GVt5Y85Xbee9wEC+ZWi5jpgyup2bmtav8h2C2wRSMG6zcs6mcQKQEsgHClvxMX+xnnS7 0MCVQMWxxW679gEZ/85vCIWx0aanksYAX7h5Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=aPurW/7y4OtLHDJkTOeBj2xM7prwGTM5JiQ/76g0eeWYEjy+cfEkfsxDQH+nXgkKUb u/rLcuKetjwm8+Zs7mvoSvyc3c8WbR4jVpA8IsDsr91fVIBBwmiZf9kiy/MVcN7n5iIX ksE9SgE4yEaYPtiwYs50TF+dQUlw8cVX+R77I= Received: by 10.227.156.14 with SMTP id u14mr12214779wbw.55.1281210709247; Sat, 07 Aug 2010 12:51:49 -0700 (PDT) Received: from localhost ([109.169.29.56]) by mx.google.com with ESMTPS id r10sm1547957wbe.6.2010.08.07.12.51.46 (version=SSLv3 cipher=RC4-MD5); Sat, 07 Aug 2010 12:51:48 -0700 (PDT) From: Anonymous To: Christian Weisgerber References: <201008071924.o77JObWZ043660@repoman.freebsd.org> Date: Sat, 07 Aug 2010 23:51:39 +0400 In-Reply-To: <201008071924.o77JObWZ043660@repoman.freebsd.org> (Christian Weisgerber's message of "Sat, 7 Aug 2010 19:24:37 +0000 (UTC)") Message-ID: <86k4o2b3qs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/connect4 Makefile pkg-descr pkg-plist ports/games/connect4/files patch-aa patch-ab patch-ac X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Aug 2010 19:51:51 -0000 Christian Weisgerber writes: > naddy 2010-08-07 19:24:37 UTC > > FreeBSD ports repository > > Modified files: > games/connect4 Makefile pkg-descr pkg-plist > games/connect4/files patch-aa patch-ab patch-ac > Log: > Remove a bogus handrolled setproctitle() from ye olden days, fixes > crashes on 64-bit archs. Add missing #includes. > > Move high-score file to /var/games. > > Better pkg-descr. > > PR: 149406 > > Revision Changes Path > 1.15 +8 -4 ports/games/connect4/Makefile Why not pass $(SCOREFILE) to vendor makefile from port's one? MAKE_ENV += SCOREFILE=${SCOREFILE} It'll save one from keeping in mind *two* places where the value is hardcoded. Otherwise, I'm not the maintainer to complain about overriding owner/group in INSTALL_(PROGRAM|DATA) rather than setting defaults. > 1.3 +17 -30 ports/games/connect4/files/patch-aa > 1.2 +83 -49 ports/games/connect4/files/patch-ab > 1.2 +10 -23 ports/games/connect4/files/patch-ac While converting diffs to unified formats you could have given patch files more descriptive names, too. The effect would be mostly same for `cvs annotate'. > 1.3 +5 -7 ports/games/connect4/pkg-descr > 1.5 +3 -2 ports/games/connect4/pkg-plist