From owner-freebsd-fs@FreeBSD.ORG Thu Sep 19 00:05:41 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 108D0952 for ; Thu, 19 Sep 2013 00:05:41 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id C9F922E65 for ; Thu, 19 Sep 2013 00:05:40 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqQEAFM+OlKDaFve/2dsb2JhbABbgz9Sgyq9OUqBN3SCJQEBAQMBAQEBICsgCwUWGAICDRkCKQEJJgYIBwQBHASHXAYMqA6SIIEpjQWBBTQHgmmBNQOVMIN6kEWDQCAygQM5 X-IronPort-AV: E=Sophos;i="4.90,933,1371096000"; d="scan'208";a="53545839" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-jnhn.mail.uoguelph.ca with ESMTP; 18 Sep 2013 20:05:39 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 85A67B3F45; Wed, 18 Sep 2013 20:05:39 -0400 (EDT) Date: Wed, 18 Sep 2013 20:05:39 -0400 (EDT) From: Rick Macklem To: Devin Teske Message-ID: <1480665076.26305077.1379549139533.JavaMail.root@uoguelph.ca> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FBD7904@LTCFISWMSGMB21.FNFIS.com> Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 7.2.1_GA_2790 (ZimbraWebClient - FF3.0 (Win)/7.2.1_GA_2790) Cc: freebsd-fs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 00:05:41 -0000 Devin Teske wrote: > > On Sep 18, 2013, at 4:00 PM, Oleksandr V. Typlyns'kyi wrote: > > > Devin, i think line 1266 in HEAD - it is line 1245 in 8-STABLE: > > http://svnweb.freebsd.org/base/head/sys/ufs/ufs/ufs_vnops.c?annotate=253998#l1266 > > http://svnweb.freebsd.org/base/stable/8/sys/ufs/ufs/ufs_vnops.c?annotate=248832#l1245 > > http://svnweb.freebsd.org/base/releng/8.4/sys/ufs/ufs/ufs_vnops.c?annotate=248833#l1245 > > And it was not MFC'ed > > Yes, my confusion was... > > 1. The PR headers say 8.4-RELEASE-p3 is affected > > 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" > > Yet... > > releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput > (read: are patched). > Did you mean "not patched"? The patched version in head has vput() and the unpatched versions have VOP_UNLOCK(), if I read the coed correctly. rick > So I'm very curious, with respect to the PR, how the test program > showed > a leak when the claim is that r253998 which fixes this, was in the > OP's branch. > -- > Devin > > _____________ > The information contained in this message is proprietary and/or > confidential. If you are not the intended recipient, please: (i) > delete the message and all copies; (ii) do not disclose, distribute > or use the message in any manner; and (iii) notify the sender > immediately. In addition, please be aware that any message addressed > to our domain is subject to archiving and review by persons other > than the intended recipient. Thank you. > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >