From owner-svn-ports-head@freebsd.org  Mon Nov 21 22:43:25 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55D70C4D3D1;
 Mon, 21 Nov 2016 22:43:25 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from anoxia.adamw.org (anoxia.adamw.org [104.225.8.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "anoxia.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C315B172E;
 Mon, 21 Nov 2016 22:43:24 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by anoxia.adamw.org (OpenSMTPD) with ESMTPSA id 613f0e81
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Mon, 21 Nov 2016 15:43:23 -0700 (MST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Subject: Re: svn commit: r426722 - in head/lang: . pocl pocl/files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <1479765873.1459.2.camel@FreeBSD.org>
Date: Mon, 21 Nov 2016 15:43:20 -0700
Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <794F78AC-D823-48FE-91CC-83D6D123C4D9@adamw.org>
References: <201611211436.uALEaprl096393@repo.freebsd.org>
 <882131e7-54d5-9d24-98de-3297a29c187a@FreeBSD.org>
 <1479765873.1459.2.camel@FreeBSD.org>
To: Koop Mast <kwm@FreeBSD.org>
X-Mailer: Apple Mail (2.3251)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 22:43:25 -0000

> On 21 Nov, 2016, at 15:04, Koop Mast <kwm@FreeBSD.org> wrote:
>=20
> On Mon, 2016-11-21 at 19:33 +0100, Mathieu Arnold wrote:
>> Le 21/11/2016 =C3=A0 15:36, Koop Mast a =C3=A9crit :
>>>=20
>>> +do-test:
>>> +	cd ${WRKSRC} && ${GMAKE} check
>> NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should
>> be
>> written as:
>>=20
>> TEST_TARGET=3D    check
>=20
> I thik I looked up MAKE_CMD once but I don't use this that often so I
> probably forgot about that. I will try to keep it in mind for the next
> time. I didn't know about TEST_TARGET existence.
>=20
> These problems have been corrected, thanks for your comments!

(Mat is right here, TEST_TARGET is the way to go here).

Just FTR, personally I=E2=80=99m really into ${DO_MAKE_BUILD}, which =
sets up all the right environment and arguments and uses the proper =
MAKE_CMD.

	${DO_MAKE_BUILD} check

DO_MAKE_BUILD is one of the most underrated macros in the ports system!

# Adam


=E2=80=94
Adam Weinberger
adamw@adamw.org
http://www.adamw.org