From owner-freebsd-net@FreeBSD.ORG  Wed Apr 22 12:47:39 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BE7471065673
	for <freebsd-net@freebsd.org>; Wed, 22 Apr 2009 12:47:39 +0000 (UTC)
	(envelope-from bms@FreeBSD.org)
Received: from out2.smtp.messagingengine.com (out2.smtp.messagingengine.com
	[66.111.4.26]) by mx1.freebsd.org (Postfix) with ESMTP id 937F58FC0C
	for <freebsd-net@freebsd.org>; Wed, 22 Apr 2009 12:47:39 +0000 (UTC)
	(envelope-from bms@FreeBSD.org)
Received: from compute1.internal (compute1.internal [10.202.2.41])
	by out1.messagingengine.com (Postfix) with ESMTP id 2A8093203DA;
	Wed, 22 Apr 2009 08:47:39 -0400 (EDT)
Received: from heartbeat2.messagingengine.com ([10.202.2.161])
	by compute1.internal (MEProxy); Wed, 22 Apr 2009 08:47:39 -0400
X-Sasl-enc: R6rQx5uv0xhesVtJlIDQWQSfJIP9FN1SkAPYXeXcbgPE 1240404458
Received: from empiric.lon.incunabulum.net (unknown [81.168.51.182])
	by mail.messagingengine.com (Postfix) with ESMTPSA id 8DDE24D67F;
	Wed, 22 Apr 2009 08:47:38 -0400 (EDT)
Message-ID: <49EF11E8.508@FreeBSD.org>
Date: Wed, 22 Apr 2009 13:47:36 +0100
From: "Bruce M. Simpson" <bms@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090412)
MIME-Version: 1.0
To: Will Andrews <will@firepipe.net>
References: <2aada3410904212216o128e1fdfx8c299b3531adc694@mail.gmail.com>
In-Reply-To: <2aada3410904212216o128e1fdfx8c299b3531adc694@mail.gmail.com>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: CARP as a module; followup thoughts
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2009 12:47:40 -0000

Hi,

Will Andrews wrote:
> Hello,
>
> I've written a patch (against 8.0-CURRENT as of r191369) which makes
> it possible to build, load, run, & unload CARP as a module, using the
> GENERIC kernel.  It can be obtained from:
>
> http://firepipe.net/patches/carp-as-module-20090421.diff
>   

There's no need to implement the in*_proto_register() stuff in that 
patch, you should just be able to re-use the encap_attach_func() 
functions. Look at how PIM is implemented in ip_mroute.c for an example.

Other than that it looks like a good start... but would hold off on 
committing as-is. the more general case of registering a MAC address on 
an interface should be considered.

cheers,
BMS