From owner-freebsd-current Sat Nov 16 12: 6: 8 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D39C737B401 for ; Sat, 16 Nov 2002 12:06:06 -0800 (PST) Received: from bunrab.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B92F43E42 for ; Sat, 16 Nov 2002 12:06:06 -0800 (PST) (envelope-from david@catwhisker.org) Received: from bunrab.catwhisker.org (localhost [127.0.0.1]) by bunrab.catwhisker.org (8.12.6/8.12.6) with ESMTP id gAGK65G8067347 for ; Sat, 16 Nov 2002 12:06:05 -0800 (PST) (envelope-from david@bunrab.catwhisker.org) Received: (from david@localhost) by bunrab.catwhisker.org (8.12.6/8.12.6/Submit) id gAGK65sm067346 for current@freebsd.org; Sat, 16 Nov 2002 12:06:05 -0800 (PST) Date: Sat, 16 Nov 2002 12:06:05 -0800 From: David Wolfskill To: current@freebsd.org Subject: Re: Asking for tester (small patch to chown(8)/chgrp(1)) Message-ID: <20021116200605.GA67266@bunrab.catwhisker.org> Mail-Followup-To: David Wolfskill , current@freebsd.org References: <200211161129.gAGBTKHJ033124@lurza.secnetix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200211161129.gAGBTKHJ033124@lurza.secnetix.de> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Nov 16, 2002 at 12:29:20PM +0100, Oliver Fromme wrote: > I've submitted a small patch (bin/45333) for both -stable > and -current, but I haven't been able to test it under > -current (due to lack of a spare machine). Would someone > please give it a try and let me know if it compiles and > works? Seems to for me (today's -CURRENT). I did take the liberty of removing the extraneous space on (the new) line 151 (so its "if" lines up with those on lines 153 & 155), and of replacing the 'usage:' on (the new) line 305 (chgrp's usage() message, showing the second alternative invocation) with whitespace (to match the pattern for chown). (If someone wants my diff, please let me know. It's not sufficiently different from what Oliver put in his PR to warrant spamming -current, as far as I'm concerned.) > The patch adds an option -r to chown(8) and chgrp(1), which > does pretty much the same as the -r option of touch(1) and > truncate(1). Basically, it let's you "copy" ownerships and > group memberships from one file to another, which is useful > in scripts. Makes sense. Only reservation I'd have -- and this may well be unfounded -- is to be sure we're not introducing gratutitous differences with respect to other implementations or to applicable standards. I have no problem with functional differences that don't break standards conformance (to the extent we claim it, anyway). > Thanks! Hope this is useful. Cheers, david (links to my resume at http://www.catwhisker.org/~david) -- David H. Wolfskill david@catwhisker.org I have no confidence in results obtained through the use of Microsoft products. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message