From owner-svn-ports-head@freebsd.org Tue Feb 16 14:24:05 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7096AA9808; Tue, 16 Feb 2016 14:24:05 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) by mx1.freebsd.org (Postfix) with ESMTP id 67F681D2D; Tue, 16 Feb 2016 14:24:05 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id VgXjazPZPsChYVgXkaIZSb; Tue, 16 Feb 2016 07:23:59 -0700 X-Authority-Analysis: v=2.1 cv=N9CJbzJB c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=jFJIQSaiL_oA:10 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=YxBL1-UpAAAA:8 a=pKcz_MTdD46ZfaVDR4cA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 89E75137F1; Tue, 16 Feb 2016 06:23:55 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u1GENtsM014622; Tue, 16 Feb 2016 06:23:55 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201602161423.u1GENtsM014622@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Pietro Cerutti cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r408973 - head/lang/dmd2 In-Reply-To: Message from Pietro Cerutti of "Tue, 16 Feb 2016 10:26:35 +0100." <3772ed9d654255d394ee12249d1f7ee8@gahr.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 16 Feb 2016 06:23:55 -0800 X-CMAE-Envelope: MS4wfFkQwOz9x4rbb6VhfU32XW4bUXOm2CxMeU/9uKhlmLrypDsR+8ReaB6UPOHkR8NNR/cQCJyaKAElF8DRz7jo+5BILZZpKWgdDB1qAamXb2GcpywI+dwX 6zYDa3lEpso9JvBbrWUI0DwvQxkk3D2UQvBWXFy++Tml2f2e7PYUr86/ibVDHrlkY4TY5k/jW8O07NbmOFxaD+EaVq9fh7d6P3JdddPcfdJH9G2DHXb1N4/V I4vp57WL5QEJ4DUbODs0oDax21RTiZ4cWtGmzavRVkY25lF7hL1xKlH/Eymp852sQamu4ajrnEujmqmteVYHqHjm8fIs4TQ+PCR5r21CQN265CjfdEZ0QNRk 7ydysGF5iC3zJ+h1vMcjwb2JBTTZ9g== X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 14:24:06 -0000 In message <3772ed9d654255d394ee12249d1f7ee8@gahr.ch>, Pietro Cerutti writes: > On 2016-02-16 04:30, Cy Schubert wrote: > > Author: cy > > Date: Tue Feb 16 03:30:06 2016 > > New Revision: 408973 > > URL: https://svnweb.freebsd.org/changeset/ports/408973 > > > > Log: > > Correctly locate dmd.conf. > > This is wrong. Your latest 2 commits result in effectively hardcoding > PREFIX to /usr/local. See the two snippets below. > Could you please revert to having posix.mak specify SYSCONFDIR=/etc and > our Makefile substitute /etc with ${PREFIX}/etc? > Or anything that is functionally equivalent. > > Thanks, > > > > > =========================================================================== > === > > --- head/lang/dmd2/Makefile Tue Feb 16 02:52:56 2016 (r408972) > > +++ head/lang/dmd2/Makefile Tue Feb 16 03:30:06 2016 (r408973) > > @@ -65,7 +66,6 @@ post-patch: > > -e "s|\\\BR|.BR|" \ > > ${WRKDIR}/dmd2/man/man1/dmd.1 \ > > ${WRKDIR}/dmd2/man/man5/dmd.conf.5 > > - @${REINPLACE_CMD} -e '/^SYSCONFDIR=/s|/etc/|${PREFIX}/etc/|' > > > ============================================================================= > = > --- head/lang/dmd2/files/patch-src__dmd__posix.mak Thu Jan 28 > 20:44:35 2016 (r407420) > +++ head/lang/dmd2/files/patch-src__dmd__posix.mak Thu Jan 28 > 20:47:32 2016 (r407421) > @@ -1,23 +1,82 @@ > ---- ../../src/dmd/posix.mak.orig 2015-11-11 02:36:12.000000000 -0800 > -+++ ../../src/dmd/posix.mak 2015-11-15 01:40:55.280252455 -0800 > -@@ -57,13 +57,13 @@ > +--- ../../src/dmd/posix.mak.orig 2016-01-27 07:22:54.000000000 -0800 > ++++ ../../src/dmd/posix.mak 2016-01-28 12:32:14.044394178 -0800 > +@@ -19,7 +19,7 @@ > + endif > + > + INSTALL_DIR=../../install > +-SYSCONFDIR=/etc > ++SYSCONFDIR=/usr/local/etc > > > > -- > Pietro Cerutti > gahr@FreeBSD.org > Thanks for noticing. It was accidently included when the patch was re-rolled for r407421. It's been removed. Thanks again. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.