From owner-svn-src-stable-10@FreeBSD.ORG Tue Feb 4 16:30:36 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E3E380B for ; Tue, 4 Feb 2014 16:30:36 +0000 (UTC) Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com [IPv6:2607:f8b0:400d:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B6F221E2B for ; Tue, 4 Feb 2014 16:30:35 +0000 (UTC) Received: by mail-qc0-f174.google.com with SMTP id x13so13942535qcv.33 for ; Tue, 04 Feb 2014 08:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=6gaJ6IqVeKQ8A3U4JaiVxxKlATsAmbUMo0gDgVdschI=; b=e6nXiVKXEr/cwefIiVfGKupcUSH6toNaTe74+7cTTBu6ukpzngsSNSobLYnvUo/57s 4oR1eg58Wsk3JdMl00Kc2pftNgGaNZipdyH7plGAm9zLgwN3ISlC0qMUti3wUaXMGAnl 6kMl2spr5BZQVFEedZI1yrRGwiPtxEIBFac4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=6gaJ6IqVeKQ8A3U4JaiVxxKlATsAmbUMo0gDgVdschI=; b=g54nJhYDIonpTjEy5uom2NsdHc7uWiNxTXya2OdmbRkAj078fcXHTFTUbZT51fXVjp /vd48wvWb5IbCmNz7g5r07aO0vXcai79YBN7p2n6aphs9mSx4XoehYjZRgYud48o+ROj MNdGqXyaw903TdqyRvrmdPBpzOTP01fbHLI+oJIeHQ2JDWzdEoO5Bfx5IGVobc28VzVp DIYWS/DOcYh6eiLKZA5XhbhKivigdEYMO5nv1rjA9A3mxIzl3ukAFSzBrOuN6L3bzbvp 1q2PO/aucc8eY+NuXhqscF2vlt0E3rK1JLmLmBwVcNVCJ83YNMSnVzCYZvuWxihXBRP3 ij0g== X-Gm-Message-State: ALoCoQk6Kz+w+ozUmiqugJrk5Eg9YlnA5373gjFWs0exw9ukwwBmt39CgK7Kis8eFbnK/WU7esg4 X-Received: by 10.224.8.70 with SMTP id g6mr3879220qag.45.1391531434821; Tue, 04 Feb 2014 08:30:34 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.30.229 with HTTP; Tue, 4 Feb 2014 08:30:04 -0800 (PST) In-Reply-To: <1391525946.13026.106.camel@revolution.hippie.lan> References: <201402040336.s143ah3l039786@svn.freebsd.org> <1391525946.13026.106.camel@revolution.hippie.lan> From: Eitan Adler Date: Tue, 4 Feb 2014 11:30:04 -0500 X-Google-Sender-Auth: nT3yYnTuprcWPV0Z098J6W0WAPY Message-ID: Subject: Re: svn commit: r261455 - in stable/10: lib/libc/sparc64/fpu lib/libc/xdr sys/amd64/pci sys/amd64/vmm/intel sys/arm/arm sys/arm/at91 sys/arm/broadcom/bcm2835 sys/arm/econa sys/arm/freescale/imx sys/arm... To: Ian Lepore Content-Type: text/plain; charset=UTF-8 Cc: svn-src-stable@freebsd.org, "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , svn-src-stable-10@freebsd.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2014 16:30:36 -0000 On Tue, Feb 4, 2014 at 9:59 AM, Ian Lepore wrote: > On Tue, 2014-02-04 at 03:36 +0000, Eitan Adler wrote: >> Author: eadler >> Date: Tue Feb 4 03:36:42 2014 >> New Revision: 261455 >> URL: http://svnweb.freebsd.org/changeset/base/261455 >> >> Log: >> MFC r258779,r258780,r258787,r258822: >> >> Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this >> shifts into the sign bit. Instead use (1U << 31) which gets the >> expected result. >> >> Similar to the (1 << 31) case it is not defined to do (2 << 30). >> >> This fix is not ideal as it assumes a 32 bit int, but does fix the issue >> for most cases. >> >> A similar change was made in OpenBSD. >> > > This is causing arm breakage, I think r258787 needs to be mfc'd to fix. As the commit log says, I included r258787 in the original svn merge line. I'm not sure why it didn't work. In any case it should be fixed now and sorry for the breakage. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams