From owner-svn-src-head@FreeBSD.ORG  Fri Aug  9 19:16:57 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 67EE1B09;
 Fri,  9 Aug 2013 19:16:57 +0000 (UTC)
 (envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 42AAD2BED;
 Fri,  9 Aug 2013 19:16:57 +0000 (UTC)
Received: from dhcp-192-168-2-38.wifi.xcllnt.net
 (50-0-150-213.dsl.static.sonic.net [50.0.150.213])
 (authenticated bits=0)
 by mail.xcllnt.net (8.14.7/8.14.7) with ESMTP id r79JGsdt046653
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Fri, 9 Aug 2013 12:16:56 -0700 (PDT)
 (envelope-from marcel@xcllnt.net)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: svn commit: r253862 - head/sys/boot/ficl
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <1V6Cmb-000M0k-0l@internal.tormail.org>
Date: Fri, 9 Aug 2013 12:17:01 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <2E62CB17-8E7E-44C0-ADD1-F58E6EDECCBE@xcllnt.net>
References: <201308011806.r71I6xpd088690@svn.freebsd.org>
 <1V65V2-0001RI-Fu@internal.tormail.org>
 <953FDB6A-11EF-46D3-85D8-634952AF9309@xcllnt.net>
 <1V6Cmb-000M0k-0l@internal.tormail.org>
To: Jan Beich <jbeich@tormail.org>
X-Mailer: Apple Mail (2.1508)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Marcel Moolenaar <marcel@FreeBSD.org>, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Aug 2013 19:16:57 -0000


On Aug 4, 2013, at 9:52 PM, Jan Beich <jbeich@tormail.org> wrote:
> 
>> 
>> It's probably not going to work on any other FS. The
>> alternative is to just not support freaddir due to lack
>> of runtime support.
> 
> What's the issue with my version in bin/172542 ? It doesn't
> use d_reclen but relies on a side-effect of readdir() call.

It leaks memory and doesn't handle the use of freaddir with
different fds interspersed. It's flawed in a different way.
FYI,

-- 
Marcel Moolenaar
marcel@xcllnt.net