From owner-svn-src-projects@FreeBSD.ORG Sat Jan 30 19:26:35 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E1E0106576B; Sat, 30 Jan 2010 19:26:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3EBF68FC21; Sat, 30 Jan 2010 19:26:35 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o0UJQZrr085199; Sat, 30 Jan 2010 19:26:35 GMT (envelope-from rwatson@svn.freebsd.org) Received: (from rwatson@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o0UJQZ70085197; Sat, 30 Jan 2010 19:26:35 GMT (envelope-from rwatson@svn.freebsd.org) Message-Id: <201001301926.o0UJQZ70085197@svn.freebsd.org> From: Robert Watson Date: Sat, 30 Jan 2010 19:26:35 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203222 - projects/capabilities8/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2010 19:26:35 -0000 Author: rwatson Date: Sat Jan 30 19:26:34 2010 New Revision: 203222 URL: http://svn.freebsd.org/changeset/base/203222 Log: Merge c171327 from the p4 TrustedBSD Capabilities branch to capabilities8: We should, of course, be setting *base to 0, not the local variable base. Submitted by: Jonathan Anderson Modified: projects/capabilities8/sys/kern/vfs_syscalls.c Modified: projects/capabilities8/sys/kern/vfs_syscalls.c ============================================================================== --- projects/capabilities8/sys/kern/vfs_syscalls.c Sat Jan 30 19:26:28 2010 (r203221) +++ projects/capabilities8/sys/kern/vfs_syscalls.c Sat Jan 30 19:26:34 2010 (r203222) @@ -165,7 +165,7 @@ getvnode_cap(struct filedesc *fdp, int f * Several *at() system calls are now supported in capability mode. This function * finds out what their "*at base" vnode, which is needed by namei(), should be: * - * 1. In non-capability (and thus unconstrained) mode, base = 0. + * 1. In non-capability (and thus unconstrained) mode, *base = 0. * 2. In capability mode, base is the vnode given by the fd parameter, subject to * the condition that the supplied 'rights' parameter (OR'ed with CAP_LOOKUP * and CAP_ATBASE) is satisfied. The vnode is returned with a shared lock. @@ -174,7 +174,7 @@ int fgetbase(struct thread *td, int fd, cap_rights_t rights, struct vnode **base) { if (!(td->td_ucred->cr_flags & CRED_FLAG_CAPMODE)) - base = 0; + *base = 0; else { int error;