From owner-freebsd-current Wed Jan 27 18:52:49 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA24391 for freebsd-current-outgoing; Wed, 27 Jan 1999 18:52:49 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from krdl.org.sg (rodin.krdl.org.sg [137.132.252.27]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA24380 for ; Wed, 27 Jan 1999 18:52:46 -0800 (PST) (envelope-from joerg@mailbox.iss.nus.sg) Received: from mailhost.krdl.org.sg (mailbox.krdl.org.sg [137.132.247.30]) by krdl.org.sg (8.9.2/8.9.2) with ESMTP id KAA04898; Thu, 28 Jan 1999 10:58:03 +0800 (SGT) Received: from negara.nus.sg (negara [137.132.248.175]) by mailhost.krdl.org.sg (8.9.0/8.9.0) with ESMTP id KAA01267; Thu, 28 Jan 1999 10:52:06 +0800 (SGT) Received: (from joerg@localhost) by negara.nus.sg (8.9.1b+Sun/8.9.1) id DAA01537; Thu, 28 Jan 1999 03:53:36 +0800 (SGT) Message-ID: <19990128035336.V496@krdl.org.sg> Date: Thu, 28 Jan 1999 03:53:36 +0800 From: "Joerg B. Micheel" To: Matthew Dillon , current@FreeBSD.ORG Subject: Re: bug in netatm/atm_cm.c ? References: <199901272215.OAA63874@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <199901272215.OAA63874@apollo.backplane.com>; from Matthew Dillon on Wed, Jan 27, 1999 at 02:15:11PM -0800 Organization: Kent Ridge Digital Labs, Singapore Project: SingAREN, the Singapore Advanced Research and Education Network Operating-System: ... drained by Solaris 7 Intel Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Jan 27, 1999 at 02:15:11PM -0800, Matthew Dillon wrote: > around line 2192. Shouldn't this be ap->aal.type == ATM_AAL5 ??? It definitely should, as the } else { branch on line 2211 is never reached. The reason it has not been discovered is that noone hardly ever uses anything other than AAL5 (as of today) and this code always defaults to it. Just wondering why nobody ever got a compiler warning with the AAL4 code never reached. Joerg -- Joerg B. Micheel Email: SingAREN Technology Center Phone: +65 8742582 Kent Ridge Digital Labs, Rm 3-65, C041 Fax: +65 7744990 21 Heng Mui Keng Terrace Pager: +65 96016020 Singapore 119613 Plan: Troubleshooting ATM Republic of Singapore Networks and Applications To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message