From owner-freebsd-ports@FreeBSD.ORG Tue Feb 3 11:55:45 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F159D16A4CE for ; Tue, 3 Feb 2004 11:55:45 -0800 (PST) Received: from postman.arcor.de (newsread1.arcor-online.net [151.189.0.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9F0743D45 for ; Tue, 3 Feb 2004 11:55:40 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from fillmore.dyndns.org (port-212-202-51-21.reverse.qsc.de [212.202.51.21]) (authenticated bits=0)i13JtNtw026690 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 3 Feb 2004 20:55:23 +0100 (MET) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD) id 1Ao6E3-0007Vv-IN; Tue, 03 Feb 2004 20:28:47 +0100 Message-ID: <401FF66F.4030907@fillmore-labs.com> Date: Tue, 03 Feb 2004 20:28:47 +0100 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: Joe Marcus Clarke References: <1075796985.964405.22320.nullmailer@sinanica.lg2a.datamax> <401F8028.6010609@fillmore-labs.com> <1075827619.780.3.camel@gyros> In-Reply-To: <1075827619.780.3.camel@gyros> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: Vasil Dimov cc: Clement Laforet cc: freebsd-ports@freebsd.org Subject: Re: ports/62302: SIZE in distinfos causes failure with FETCH_CMD=wget X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 19:55:46 -0000 Joe Marcus Clarke wrote: > On Tue, 2004-02-03 at 06:04, Oliver Eikemeier wrote: > >>Vasil Dimov wrote: >> >>>[...] >>>Existence of the SIZE line causes `-S bytes' to be passed to the fetch command >>>(according to FETCH_CMD). As it appears wget does not support this feature. >> >>You run into a similar problem if you have distfiles in /cdrom/ports/distfiles >>and do `make FETCH_CMD=wget FETCH_SYMLINK_DISTFILES=yes fetch'. The problem gets >>worse if you do `make FETCH_CMD=curl fetch'. Either: >> >>- only `fetch' is supported, and you can use FETCH_CMD only to specify a different >> path to the binary >> >>or >> >>- we have a reason to support other file transfer utilities (e.g. they support >> distributed downloading or special firewall protocols) and have to fix this. >> >>So, what do you think? > > This is fixed in the current bento run as a DISABLE_SIZE macro has been > added. Defining this in /etc/make.conf will disable the -S argument. > As well, SIZE attributes are now recorded by default unless NO_SIZE is > defined. > > Joe This does not fix FETCH_SYMLINK_DISTFILES nor support curl. Do we support different file transfer utilities (wget, curl) or don't we? If we want to, we could use something like FETCH_EXTRA_ARGS= -ARr FETCH_EXTRA_ARGS+= $${CKSIZE:+-S $$CKSIZE} FETCH_CMD?= /usr/bin/fetch ${FETCH_EXTRA_ARGS} which is easily extensible to support other tools. -Oliver