From owner-freebsd-current@FreeBSD.ORG Sat Nov 4 07:46:33 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B330316A403 for ; Sat, 4 Nov 2006 07:46:33 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1105443D5A for ; Sat, 4 Nov 2006 07:46:29 +0000 (GMT) (envelope-from kip.macy@gmail.com) Received: by nf-out-0910.google.com with SMTP id i2so1736409nfe for ; Fri, 03 Nov 2006 23:46:27 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NJPwW+V78l+UuTxA3DrEa35Oz4JiDxrWnojMOYhn1hlndpf9poTQERyXUFMQg8FexJEfIxNsoGXgPg2C1831QNHkuD6Dmws1awluGFAUAPlyeQN3qBKm9ITZLpM8db24moI3xLWMh2aHKWgRRP1OaEwfjuW9BmhkLBgQqBXIBak= Received: by 10.82.182.8 with SMTP id e8mr963525buf.1162626387153; Fri, 03 Nov 2006 23:46:27 -0800 (PST) Received: by 10.82.191.20 with HTTP; Fri, 3 Nov 2006 23:46:27 -0800 (PST) Message-ID: Date: Fri, 3 Nov 2006 23:46:27 -0800 From: "Kip Macy" To: "John Birrell" , "FreeBSD Tinderbox" , current@freebsd.org, sparc64@freebsd.org In-Reply-To: <20061104070047.GA98215@what-creek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061104060421.6145773068@freebsd-current.sentex.ca> <20061104070047.GA98215@what-creek.com> Cc: Subject: Re: [head tinderbox] failure on sparc64/sun4v X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2006 07:46:33 -0000 Sparc64 only supports CAS on 4 and 8 byte quantities. The only operation it support on 16 bytes is load. -Kip On 11/3/06, John Birrell wrote: > On Sat, Nov 04, 2006 at 01:04:21AM -0500, FreeBSD Tinderbox wrote: > > [...] > > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration > of 'atomic_add_16' was here > > /src/sys/netinet/sctp_pcb.c:3470: warning: nested extern declaration of > `atomic_add_16' > > /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of > 'atomic_add_16' > > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration > of 'atomic_add_16' was here > > /src/sys/netinet/sctp_pcb.c: In function `sctp_load_addresses_from_init': > > /src/sys/netinet/sctp_pcb.c:4382: warning: nested extern declaration of > `atomic_add_16' > > /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of > 'atomic_add_16' > > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration > of 'atomic_add_16' was here > > *** Error code 1 > > This is a problem on sparc64 and sun4v because we don't have an > atomic_add_16. > > I looked at the code in Solaris to see what asm is required to implement > it and it takes 22 statements compared to 2 for a 64 bit variable and 4 for > a 32 bit variable. > > Can't the code be changed to use a more typical variable size of the > arches we have? 32 bits would be a better choice. > > -- > John Birrell > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >