From owner-svn-src-all@FreeBSD.ORG  Thu Aug  8 10:06:45 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7903A5E0;
 Thu,  8 Aug 2013 10:06:45 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-qa0-x22a.google.com (mail-qa0-x22a.google.com
 [IPv6:2607:f8b0:400d:c00::22a])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 090922527;
 Thu,  8 Aug 2013 10:06:44 +0000 (UTC)
Received: by mail-qa0-f42.google.com with SMTP id bv4so191163qab.15
 for <multiple recipients>; Thu, 08 Aug 2013 03:06:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=H/udqRgQtaSYJCrAjG44C3GQCCZ3i5kM7vgyGRkT/4Y=;
 b=SulMqOpEwuzYgE73Qp2wbStqy2ulE5aRzrdEjwhuLNmpWkyX7NdNuJKK/5brp0OYmD
 oKntsKZChY7TPzR+z6idXssrI4Bp6lln3Bc8jIFm7l/luqYaaD9F/mZGhk4vTCE1y6Bm
 UcGyVY7Lm3Sn7LL/FRAGe47BVTMXS0ey9+giUDgXKsbYEY1uOCB/erVFDgIJKgk9iri6
 DlUXPJYwY8VRy25SrJL83GyagQP01AQpbnrZTeGt/1VGWF0Bjey/RDAyb+49y+96rfJK
 Pzbu3p++qWkMjxOc0SP5kqoy36fIL9DoSsVFVRdegdXBgbR42uHy42FlDceKoX6Ogo49
 4+rQ==
MIME-Version: 1.0
X-Received: by 10.224.127.137 with SMTP id g9mr5156369qas.4.1375956404161;
 Thu, 08 Aug 2013 03:06:44 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.128.70 with HTTP; Thu, 8 Aug 2013 03:06:44 -0700 (PDT)
In-Reply-To: <20130808092343.GP20104@FreeBSD.org>
References: <201308080509.r7859aWv084743@svn.freebsd.org>
 <20130808092343.GP20104@FreeBSD.org>
Date: Thu, 8 Aug 2013 03:06:44 -0700
X-Google-Sender-Auth: wGTqtQRa2TM_7T-D80wPVMCn-zo
Message-ID: <CAJ-VmomOjQ8qaB2Xor67s_GOEPUir_o_k9sLUj1P+ZmsF=tYbg@mail.gmail.com>
Subject: Re: svn commit: r254082 - head/sys/net80211
From: Adrian Chadd <adrian@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Aug 2013 10:06:45 -0000

Hi,

I'm going to eventually nuke OACTIVE. It just doesn't hold any meaning nowdays.

Having OACTIVE serialised behind the iflock doesn't actuallly help as
much as it used to - because there's multiple concurrent TX path entry
points, it's very possible that OACTIVE will get set in one TXing
thread during the _middle_ of the execution of another TX thread.
That's why you need some kind of higher level serialisation or locking
around the TX path to have it make any sense.




-adrian