From owner-cvs-all@FreeBSD.ORG  Fri Aug  5 02:47:50 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4BA9C106566C;
	Fri,  5 Aug 2011 02:47:50 +0000 (UTC)
	(envelope-from bf1783@googlemail.com)
Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com
	[209.85.213.54])
	by mx1.freebsd.org (Postfix) with ESMTP id B6CC18FC08;
	Fri,  5 Aug 2011 02:47:49 +0000 (UTC)
Received: by ywm39 with SMTP id 39so1824773ywm.13
	for <multiple recipients>; Thu, 04 Aug 2011 19:47:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=mime-version:reply-to:in-reply-to:references:date:message-id
	:subject:from:to:cc:content-type;
	bh=wArBezQtXpazATZ2ZLmh9ejkZC8PX0RMP0NN/WrAmaI=;
	b=Y7vYzeWpP1VLYyIr+X94ay0hr5y9cThezC8Cn4L2MgjM6SIzhJaEuKSHvJxZ2wxX8c
	Cntg1WB7HcFPIXqE0XrC+meQhpiRjzBBcNuVsMLs9f/wtaPGaSb6M56pKbBCmT2OBgAb
	72dC6jWpZKV78kv7w0g2Sq83OsSdNfJ/zQh8Q=
MIME-Version: 1.0
Received: by 10.142.48.20 with SMTP id v20mr1555003wfv.115.1312512468595; Thu,
	04 Aug 2011 19:47:48 -0700 (PDT)
Received: by 10.68.43.133 with HTTP; Thu, 4 Aug 2011 19:47:48 -0700 (PDT)
In-Reply-To: <20110805021028.GD12696@bonjour.sunpoet.net>
References: <201108042336.p74NaqwG020915@repoman.freebsd.org>
	<20110805021028.GD12696@bonjour.sunpoet.net>
Date: Thu, 4 Aug 2011 22:47:48 -0400
Message-ID: <CAGFTUwOQFJxX7_CJHGKutA15Y=+nGvBPG8w_fXeQ16seBG+8jw@mail.gmail.com>
From: "b. f." <bf1783@googlemail.com>
To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org,
	Brendan Fabeny <bf@freebsd.org>
Subject: Re: cvs commit: ports/www/youtube_dl Makefile distinfo
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: bf1783@gmail.com
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2011 02:47:50 -0000

On 8/4/11, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> On Thu, Aug 04, 2011 at 11:36:52PM +0000, Brendan Fabeny wrote:
>> bf          2011-08-04 23:36:52 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     www/youtube_dl       Makefile distinfo
>>   Log:
>>   update to 2011-08-04
>>
>>   Approved by:    araujo
>>
>>   Revision  Changes    Path
>>   1.58      +3 -3      ports/www/youtube_dl/Makefile
>>   1.48      +2 -2      ports/www/youtube_dl/distinfo
>
> Hi,
>
> I noticed that you change ${DISTDIR}/${DIST_SUBDIR} to ${_DISTDIR}.
> IMHO, it would be better not to use _foo variables as they are named for
> internal use.
> Thanks.

Yes, that seems to be the convention.  But it is a rather pedantic
objection to level in this case, where the variable is more of an
abbreviation, than a variable strictly internal to bsd.port.mk whose
value or role is likely to be changed.  Are you aware of any plans to
do so?

In any event, I'll revert that part of the change.

b.