Date: Fri, 6 Nov 2015 13:08:11 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290437 - head/usr.bin/netstat Message-ID: <563D16BB.6060908@FreeBSD.org> In-Reply-To: <201511060843.tA68hCov032306@repo.freebsd.org> References: <201511060843.tA68hCov032306@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/6/2015 12:43 AM, Garrett Cooper wrote: > Author: ngie > Date: Fri Nov 6 08:43:12 2015 > New Revision: 290437 > URL: https://svnweb.freebsd.org/changeset/base/290437 >=20 > Log: > Fix compiling netstat after r290367 by substituting sys/types.h for > sys/param.h, as sys/param.h defines the MAX(..) macro > =20 > Reported by: O. Hartmann <ohartman@zedat.fu-berlin.de> > Pointyhat to: ume >=20 > Modified: > head/usr.bin/netstat/if.c >=20 > Modified: head/usr.bin/netstat/if.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/netstat/if.c Fri Nov 6 05:32:18 2015 (r290436) > +++ head/usr.bin/netstat/if.c Fri Nov 6 08:43:12 2015 (r290437) > @@ -37,7 +37,7 @@ static char sccsid[] =3D "@(#)if.c 8.3 (Be > #include <sys/cdefs.h> > __FBSDID("$FreeBSD$"); > =20 > -#include <sys/types.h> > +#include <sys/param.h> > #include <sys/protosw.h> > #include <sys/socket.h> > #include <sys/socketvar.h> >=20 This is strange, it was building fine for days, and builds fine for me locally with reverting this change. While this may be proper, how is this a 'fix compiling' and a 'pointyhat'? --=20 Regards, Bryan Drewery --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWPRa7AAoJEDXXcbtuRpfPCnUIAL4xrL2sp53jnNoPPu6qMUPS TFbjUMOBdCBIkSSY8t/5zY+J4lkqVJfKSgWM4MjH2YScI6RznVB8yXbp0bHf5e8d Jh3MCuQV2neygQD+Q8lZv8OCiqI4YGNOl72MiXw454wvRgbOREF3o+cPkkNN+SAN /JNZCFxrjJ40cCeQiVvU8NcAvQ+VNtB85PAPyi08+oIOuokkUPkoogzV6AsIZ3r5 l4OktDkIANJAr8MICEkfzG5gxT4lUlIEiOwtDlFhP2tpzgix/DuvdfcEBqSMxSDP 46BYOcXhnpmQ5g+k9Qqg74simYjE4F1pPDF+FkbNOhBxrEpzLE/u2+Zmen8FOmw= =L35k -----END PGP SIGNATURE----- --oXOUQBpAl8nQAOnkbtaTJp6r0A6EM8F5c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?563D16BB.6060908>