From owner-freebsd-hackers  Tue Jan 21 20: 3: 1 2003
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B29AE37B401
	for <hackers@FreeBSD.ORG>; Tue, 21 Jan 2003 20:03:00 -0800 (PST)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5579F43F13
	for <hackers@FreeBSD.ORG>; Tue, 21 Jan 2003 20:03:00 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.6/8.12.6) with ESMTP id h0M42x0i000194;
	Tue, 21 Jan 2003 20:02:59 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.6/8.12.6/Submit) id h0M42xBo000193;
	Tue, 21 Jan 2003 20:02:59 -0800 (PST)
Date: Tue, 21 Jan 2003 20:02:59 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200301220402.h0M42xBo000193@apollo.backplane.com>
To: Kris Kennaway <kris@obsecurity.org>
Cc: hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com>
Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel
References: <200301220325.h0M3PiNt099890@apollo.backplane.com> <20030121195803.A32701@citusc.usc.edu>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


:On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote:
:>     This patch is going to go in on the weekend unless someone has any
:>     worthwhile nits about it.  It was submitted by Hiten Pandya.
:
:> Index: contrib/dev/oltr/if_oltr.c
:
:> Index: contrib/ipfilter/netinet/ip_proxy.c
:
:> Index: netinet6/nd6.c
:
:You shouldn't modify vendor code for minor purposes.
:
:Kris

    The vendor code in question has been modified *extensively* since
    it was imported, (and of course I would give Darren a head's up in
    regards to ipfilter).  Unless you have a more specific reason I don't
    really think a general blanket statement is sufficient reason to not
    do the commit, at least not in this case.

						-Matt


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message