From owner-cvs-all@FreeBSD.ORG Fri Jun 5 17:22:48 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58747106564A; Fri, 5 Jun 2009 17:22:48 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.freebsd.org (Postfix) with ESMTP id 053D38FC15; Fri, 5 Jun 2009 17:22:48 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id 59EEB2C50CD5; Fri, 5 Jun 2009 20:23:15 +0300 (EEST) Date: Fri, 5 Jun 2009 20:23:13 +0300 From: Ion-Mihai Tetcu To: Gabor Kovesdan Message-ID: <20090605202313.686a6929@it.buh.tecnik93.com> In-Reply-To: <4A29493F.7030004@FreeBSD.org> References: <200906051159.n55BxGPw078489@repoman.freebsd.org> <4A29485C.3060504@FreeBSD.org> <4A29493F.7030004@FreeBSD.org> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/JR9/ebXSpDbWG_IHn.+JBZt"; protocol="application/pgp-signature" Cc: Gabor Pali , cvs-ports@FreeBSD.org, Doug Barton , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/hs-alex Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 17:22:48 -0000 --Sig_/JR9/ebXSpDbWG_IHn.+JBZt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 05 Jun 2009 18:35:11 +0200 Gabor Kovesdan wrote: > Doug Barton escribi=C3=B3: > > Gabor Pali wrote: > > =20 > >> pgj 2009-06-05 11:59:16 UTC > >> > >> FreeBSD ports repository > >> > >> Modified files: > >> devel/hs-alex Makefile=20 > >> Log: > >> - Respect custom PREFIX, LOCALBASE > >> - Bump port revision > >> =20 > >> Reported by: QAT > >> Approved by: gabor (mentor) > >> =20 > >> Revision Changes Path > >> 1.27 +7 -0 ports/devel/hs-alex/Makefile > >> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/hs-alex/Makefile.dif= f?&r1=3D1.26&r2=3D1.27&f=3Dh > >> > >> =20 > > > > I can't see any reason for a PORTREVISION bump here. Kudos for > > fixing this issue, but if we do bumps for every time nothing but > > this is fixed our users are going to be doing a lot of needless > > recompiles for no benefit. > > =20 > As approver, I also thought about this but some people might use a=20 > different PREFIX/LOCALBASE configuration constantly and in this case > a rebuild is necessary to get this port installed correctly. I don't > think using custom PREFIX/LOCALBASE is widespread but theoretically > it is possible that there are such people. The bump was not needed here since the port didn't build at all with custom LOCALBASE/PREFIX. Since it didn't build it couldn't have been installed or packaged, so no need to bump. In the general case I think we should bump PORTREVISION when fixing something, even for non-default configurations since there's no other way for a user to know to upgrade. Some disagree. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/JR9/ebXSpDbWG_IHn.+JBZt Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkopVIMACgkQJ7GIuiH/oeWqZwCfYXHZpLjlexKgIulrsefjoma2 E2wAmwU+n1y1ZCa9eZh7rKGr7iSjicOm =xmpC -----END PGP SIGNATURE----- --Sig_/JR9/ebXSpDbWG_IHn.+JBZt--