Date: Sun, 15 Jul 2001 01:11:44 +0200 From: Alexander Langer <alex@big.endian.de> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: net@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: review request: if_faith modernization Message-ID: <20010715011143.A97334@fump.kawo2.rwth-aachen.de> In-Reply-To: <20010714144147.A27610@Odin.AC.HMC.Edu>; from brooks@one-eyed-alien.net on Sat, Jul 14, 2001 at 02:41:47PM -0700 References: <20010714144147.A27610@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Brooks Davis (brooks@one-eyed-alien.net): People. This is a good example why style fixes shouldn't happen with content fixes. I can't figure out what changed in this file: > RCS file: /home/ncvs/src/sys/modules/Makefile,v > retrieving revision 1.190 > diff -u -r1.190 Makefile > --- sys/modules/Makefile 2001/07/08 04:17:26 1.190 > +++ sys/modules/Makefile 2001/07/13 23:10:49 > diff -u -r1.6 if_faith.c > --- sys/net/if_faith.c 2001/07/05 14:42:54 1.6 > +++ sys/net/if_faith.c 2001/07/14 01:21:02 I'm just curious: Why don't you need to include sys/module.h? You don't include any other file that itself includes it, but module.h defines DECLARE_MODULE and friends, which you are using. I'm a little bit confused :-) > +#include <machine/bus.h> /* XXX: Shouldn't really be required! */ Why do you include it then? :-) Haven't looked at the other stuff. Thanks Alex To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010715011143.A97334>