From owner-svn-src-all@freebsd.org Tue Dec 3 21:30:34 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBD961BE10D; Tue, 3 Dec 2019 21:30:34 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47SFWt547rz3yVV; Tue, 3 Dec 2019 21:30:34 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qk1-f178.google.com with SMTP id m188so5057197qkc.4; Tue, 03 Dec 2019 13:30:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xo/TniFzb6ZHUGTe2ojsr0rguw5FWP1xkz339i44PmU=; b=pUNjJQPwBNiEDR3fQJUI5EVW6zIKO7Fn4W6v50qtehA4rAHFqFql+cm2CVeTtSCVsN f4KWG/QZFuY+PlXxgBbvvOHG6UOa8S9lkLJmYuy/AHpSVFh36ZnYD0M+XzbEG6CDAiIc 83o0FhTxN9sqxRYgdvOZzVRLTNcJnhz3voSMQaxcTQ8nBh5Fyk2W0cE0VZ/t5vDcH+F6 sgCQpT/Q6L4yJWlgXbUOcoTU6CutkDqOuQ5Ep0ox5IPe0SOUB2lIjVFDEz8h6r5Zy/95 e3mVO9xYzVK4njHt/JD9QofxC4b64s3u/FcIfOsmbKsWz4GJwQpZLSptVSVOInI1HP66 9Qmw== X-Gm-Message-State: APjAAAVZvqW6MDCSe/VWLdFMTij168Xa22qQl2CuFErC4dzq5F76Vzjf jq+dEvFlqmrPd/TocZ0olFsDwLcDWlM= X-Google-Smtp-Source: APXvYqyiq3NM0qHGvsrHWA5WHJDukSRTlvapHLWv4ROESoldDmM1Jl9oDIOBalc7RKMl1T//vJviQg== X-Received: by 2002:a37:444c:: with SMTP id r73mr7438274qka.418.1575408632808; Tue, 03 Dec 2019 13:30:32 -0800 (PST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com. [209.85.222.173]) by smtp.gmail.com with ESMTPSA id j3sm2357292qkk.133.2019.12.03.13.30.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2019 13:30:32 -0800 (PST) Received: by mail-qk1-f173.google.com with SMTP id b8so5047937qkk.5; Tue, 03 Dec 2019 13:30:32 -0800 (PST) X-Received: by 2002:a05:620a:1fa:: with SMTP id x26mr7617642qkn.311.1575408632397; Tue, 03 Dec 2019 13:30:32 -0800 (PST) MIME-Version: 1.0 References: <201911271949.xARJnuFl084178@repo.freebsd.org> <20191203204313.GB2706@FreeBSD.org> In-Reply-To: From: Ryan Libby Date: Tue, 3 Dec 2019 13:30:20 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r355137 - head/sys/vm To: Ian Lepore Cc: Gleb Smirnoff , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47SFWt547rz3yVV X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 21:30:34 -0000 On Tue, Dec 3, 2019 at 1:12 PM Ian Lepore wrote: > > On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > > + * XXX UMA_ZONE_OFFPAGE. > > All over freebsd we have cryptic XXX comments that have no meaning to > anyone except whoever wrote them (and, I suspect, no meaning to those > people either after a couple months have elapsed). > > To the degree that XXX represents "possible trouble here" and/or "more > work to do here", I would argue that any placement of a new XXX > requires at least a sentence (and probably more like a paragraph) to > describe why it's there. > > -- Ian Yes, I agree it is cryptic. This specific XXX is discussed in the review and is a cookie crumb for planned future work: https://reviews.freebsd.org/D20722?id=64944#inline-140550 In this case the problem is pre-existing and the comment calls it out so that we don't miss it in a coming cleanup. I wrote the block comment directly above so that it would make sense when the correct flag check is eventually inserted. Ryan