From owner-svn-src-all@freebsd.org Tue Aug 27 20:52:26 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D102BDF4D9; Tue, 27 Aug 2019 20:52:26 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46J1K60Gptz4KlS; Tue, 27 Aug 2019 20:52:25 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-oi1-x244.google.com with SMTP id n1so368409oic.3; Tue, 27 Aug 2019 13:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=QF4+lV8v3y4nxPFIiwTZhp88PFS8EiaULbV0A6vPNpY=; b=Km2ov92QD3o3kal4GhR5Mxa3gvoHldCLsm+yBC0urDWDYnbMmUNrHU8fLvOrspaneI /ezSOuet+1EkYbNf4wkAR/n3EpzXNC3lPtD5l/0SkEjeR8GiT6OjU8otma+GCzkUdgVD 1WT4ksWgPKTEK+DoEmOhDW4DE0gZE3vLYE3bsBq+8AII660nBs+rLPEBwjLvNLtdXh/C D+EeFLyQ1UgEoln/cXqSG2VwVTBJHxC15bSHmWLRf0fzMueMcOcqvddFUqg6dF1T8tUO Mydwciie/fbay3lmbfRuq/bAnLHxIzIuJ3NIsWZJQ8GVz/tfWfmwx/n6Cous8B5zWG2R xYJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=QF4+lV8v3y4nxPFIiwTZhp88PFS8EiaULbV0A6vPNpY=; b=LC40ryVTDh/lqzMCmWkgch6Pv5nQ1HfMnTdeCF8zj8Hy7SOIA3Z2XXcmabR/+Ezehg 43Jmo7QobUh6QT9+tlQOF+BAYhaKBV4/jJ0ecqk4cH6b/ZKwwT1tYEeglrP2BD6gMmx2 +bOd0k9IWviY4MIRfoGZaIydXA1eFuU1I9avVc5UTbhEY9Rk5cIC0Hp8wSMAT0XgMgv8 dJjEeWNuqkKUmwY/hD5eUDs6GN4Mgs7Ss1/tnU3IJPwiPJj/7IZFyWab4xBapfQygctJ TcPYWcHzfr8NeKadQpuIAxVx98BWITAngDEYgqhe8SWlQcqHKsW7ET9y5jhtNwn6bTr8 8KKg== X-Gm-Message-State: APjAAAW4t7CNjo+0OmGmgD7a3tFyvdtS/3YERIWagg8CtCAA2OZwjQ2v 2Lk0Ctv/pXVPNG8WVwHJDaVyA489fJDlF7N7jXwu6w== X-Google-Smtp-Source: APXvYqwoPcPQIZ4JpvywE/FVBKqRFwofGx15biQjdZVVCqBMjaaVcwTpn6v6QuOor1Fp5gVyP747JQWcKRzDlNja+KQ= X-Received: by 2002:aca:4b86:: with SMTP id y128mr453056oia.163.1566939144092; Tue, 27 Aug 2019 13:52:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:2516:0:0:0:0:0 with HTTP; Tue, 27 Aug 2019 13:52:23 -0700 (PDT) In-Reply-To: <201908272030.x7RKUvuU010749@repo.freebsd.org> References: <201908272030.x7RKUvuU010749@repo.freebsd.org> From: Mateusz Guzik Date: Tue, 27 Aug 2019 22:52:23 +0200 Message-ID: Subject: Re: svn commit: r351555 - head/sys/kern To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46J1K60Gptz4KlS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Km2ov92Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2607:f8b0:4864:20::244 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; IP_SCORE(0.00)[ip: (2.32), ipnet: 2607:f8b0::/32(-2.86), asn: 15169(-2.33), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[4.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Aug 2019 20:52:26 -0000 On 8/27/19, Mateusz Guzik wrote: > Author: mjg > Date: Tue Aug 27 20:30:56 2019 > New Revision: 351555 > URL: https://svnweb.freebsd.org/changeset/base/351555 > > Log: > vfs: stop passing LK_INTERLOCK to VOP_UNLOCK > > The plan is to drop the flags argument. There is also a temporary bug > now that nullfs ignores the flag. > > Reviewed by: kib > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D21252 > Ops. That's of course https://reviews.freebsd.org/D21426 > Modified: > head/sys/kern/vfs_subr.c > > Modified: head/sys/kern/vfs_subr.c > ============================================================================== > --- head/sys/kern/vfs_subr.c Tue Aug 27 20:11:45 2019 (r351554) > +++ head/sys/kern/vfs_subr.c Tue Aug 27 20:30:56 2019 (r351555) > @@ -1034,8 +1034,8 @@ vlrureclaim(struct mount *mp, bool reclaim_nc_src, > int > (vp->v_iflag & VI_FREE) != 0 || > (vp->v_object != NULL && > vp->v_object->resident_page_count > trigger)) { > - VOP_UNLOCK(vp, LK_INTERLOCK); > - vdrop(vp); > + VOP_UNLOCK(vp, 0); > + vdropl(vp); > goto next_iter_mntunlocked; > } > KASSERT((vp->v_iflag & VI_DOOMED) == 0, > @@ -1398,7 +1398,8 @@ vtryrecycle(struct vnode *vp) > */ > VI_LOCK(vp); > if (vp->v_usecount) { > - VOP_UNLOCK(vp, LK_INTERLOCK); > + VOP_UNLOCK(vp, 0); > + VI_UNLOCK(vp); > vn_finished_write(vnmp); > CTR2(KTR_VFS, > "%s: impossible to recycle, %p is already referenced", > @@ -1409,7 +1410,8 @@ vtryrecycle(struct vnode *vp) > counter_u64_add(recycles_count, 1); > vgonel(vp); > } > - VOP_UNLOCK(vp, LK_INTERLOCK); > + VOP_UNLOCK(vp, 0); > + VI_UNLOCK(vp); > vn_finished_write(vnmp); > return (0); > } > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik