From owner-svn-src-all@freebsd.org  Thu Feb 11 09:15:36 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 008A2AA582C;
 Thu, 11 Feb 2016 09:15:36 +0000 (UTC)
 (envelope-from dwmalone@maths.tcd.ie)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 02F762C3;
 Thu, 11 Feb 2016 09:15:35 +0000 (UTC)
 (envelope-from dwmalone@maths.tcd.ie)
Received: from salmon.maths.tcd.ie (localhost [127.0.0.1])
 by salmon.maths.tcd.ie (Postfix) with ESMTP id CF97B1591BF;
 Thu, 11 Feb 2016 09:15:26 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=maths.tcd.ie; h=
 user-agent:in-reply-to:content-disposition:content-type
 :content-type:mime-version:references:message-id:subject:subject
 :from:from:date:date:received:received:received; s=20150418; t=
 1455182117; x=1456996518; bh=+hTzNB/pDIP+Ffr1Pt3n7JLs6j//LglDpGD
 3MGoqMIY=; b=CgHmhDqVWpwI182kfbNhcySd2rZ6epIhbep2tWBCii68anao1Nw
 Zh30IvuIe/+0A+pqtIoG644T9+8GmouY4mziV9nVS+u7PVh44Znjf1lSz+CU7FSf
 NLQKRVA2OwQD1kC1Lp2BJ8qaUyDAHsX/lSWfON005y3LbIOQixGFymFc=
X-Virus-Scanned: amavisd-new at maths.tcd.ie
Received: from salmon.maths.tcd.ie ([127.0.0.1])
 by salmon.maths.tcd.ie (salmon.maths.tcd.ie [127.0.0.1]) (amavisd-new,
 port 10024)
 with ESMTP id rnHVW5rrJnFn; Thu, 11 Feb 2016 09:15:17 +0000 (GMT)
Received: from smtp.maths.tcd.ie (walton.maths.tcd.ie
 [IPv6:2001:770:10:300::86e2:510a])
 by salmon.maths.tcd.ie (Postfix) with ESMTP id 219781591B1;
 Thu, 11 Feb 2016 09:15:17 +0000 (GMT)
Received: by smtp.maths.tcd.ie (Postfix, from userid 238)
 id 1D6EB7309F; Thu, 11 Feb 2016 09:15:17 +0000 (GMT)
Date: Thu, 11 Feb 2016 09:15:16 +0000
From: David Malone <dwmalone@maths.tcd.ie>
To: Stefan Esser <se@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r295465 - head/usr.sbin/services_mkdb
Message-ID: <20160211091516.GA37735@walton.maths.tcd.ie>
References: <201602100940.u1A9ejb6086175@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201602100940.u1A9ejb6086175@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Feb 2016 09:15:36 -0000

On Wed, Feb 10, 2016 at 09:40:45AM +0000, Stefan Esser wrote:
> Author: se
> Date: Wed Feb 10 09:40:45 2016
> New Revision: 295465
> URL: https://svnweb.freebsd.org/changeset/base/295465
> 
> Log:
>   Remove O_SYNC from the options passed to dbmopen().
>   
>   The services db is created as a temporary file that is moved over the
>   existing file after completion. Thus there is no need to immediately
>   flush all created db records to the temporary file.

This was changed to fix a problem with fsync not being called, which
can leave the db files empty after a sudden reboot. O_SYNC is not
the right fix, but I think I've found the real problem and there
is an open phabricator report on this, which fixes the problem in
a better way:

	https://reviews.freebsd.org/D5186

Reviews appreciated.

	David.